Rfj 22 save to pdf #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pdf fucntions to state
buttons that use controller pdf functions
define html area for screen cap to pdf
pdf modules installed fields in pdf
added next canary because build stalled until deleted .next directory
charges need rework before pdf storage as json makes label the order better to store label in charge object, in charges array in json
|
Awesome! Thank you so much for this PR. We will be taking a look at it. |
|
anything you need from me to review this pull request? or my other two PR? |
cmazzullo
approved these changes
Mar 24, 2020
|
This is approved but also has a conflict. |
|
@blingit is taking this! |
removed extra pdf code saving fields to pdf working on persistence per field edit
but charges are not resetting
|
@cmazzullo @froi |
|
Are this and the other three PR still being reviewed? |
|
Hi @Fran33. Sorry for not keeping up with this. I'll take a look at it between today and tomorrow. |
|
@froi, any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to merge Fran33 branch RFJ-22-Save-to-PDF into codefordc rfj master branch
This may be considered a draft edition of PDF because I added two ways and both depends on some form revision. I think the charges list should be changed from json to an array to help PDF have some absolute sequencing. I also added two way to PDF, one a screen capture and one a field display.
This task also taught me how to add new functions to the state for use in both controller and components. Not sure where I should add that as lesson learned.