Issue #3475110 by joshua1234511, richardgaunt, sime, granticusiv: Illegal access to constants in shipshape on govcms #1314

joshua-salsadigital · 2024-10-28T08:29:01Z

https://www.drupal.org/project/civictheme/issues/3475110

Checklist before requesting a review

I have formatted the subject to include ticket number as Issue #123456 by drupal_org_username: Issue title
I have added a link to the issue tracker
I have provided information in Changed section about WHY something was done if this was not a normal implementation
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
I have run new and existing relevant tests locally with my changes, and they passed
I have provided screenshots, where applicable

Changed

Fixed FileSystemInterface replace behaviour constants deprecated and replaced with an enum. - https://www.drupal.org/node/3426517

{"message"=>"file: /builds/xxx/yyy/themes/civictheme/src/CivicthemeStylesheetGenerator.php:\n - line 174: Cannot access constant EXISTS_REPLACE on Drupal\\Core\\File\\FileSystemInterface"}
{"message"=>"file: /builds/xxx/yyy/themes/civictheme/src/Settings/CivicthemeSettingsFormSectionBase.php:\n - line 146: Cannot access constant EXISTS_REPLACE on Drupal\\Core\\File\\FileSystemInterface"}
{"message"=>"file: /builds/xxx/yyy/themes/civictheme/theme-settings.provision.inc:\n - line 575: Cannot access constant EXISTS_REPLACE on Drupal\\Core\\File\\FileSystemInterface"}

Screenshots

…ated and replaced with an enum.

joshua-salsadigital · 2024-10-28T08:30:16Z

@richardgaunt

{"message"=>"file: /builds/xxx/yyy/themes/civictheme/src/CivicthemeColorManager.php:\n - line 330: Cannot access constant VERSION on Drupal"}
-- Cannot replicate issue.
Not an issue, \Drupal::VERSION is valid https://api.drupal.org/api/drupal/core%21lib%21Drupal.php/constant/Drupal%3A%3AVERSION/10

…ated and replaced with an enum.

joshua-salsadigital · 2024-10-28T14:18:35Z

@richardgaunt Pending

Update drupal core to 10.3
Update govcms to https://github.com/govCMS/GovCMS/releases/tag/3.18.0
Testing.

joshua-salsadigital · 2024-10-28T14:37:54Z

@richardgaunt
Issue reported on govcms https://www.drupal.org/project/civictheme/issues/3475110
lastest govcms is still on https://github.com/govCMS/GovCMS/tree/3.18.0
10.2.7

https://github.com/govCMS/GovCMS/blob/3.18.0/composer.json#L41C9-L41C45

And the deprecated errors will occur only after moving to 10.3

build-isolated-php-84 build-isolated-php-84-next

joshua-salsadigital · 2024-11-08T06:22:33Z

@richardgaunt Updated to lastest govcms along with Drupal core.

Changelogs summary:

 - php-http/discovery updated from 1.19.4 to 1.20.0 minor
   See changes: https://github.com/php-http/discovery/compare/1.19.4...1.20.0
   Release notes: https://github.com/php-http/discovery/releases/tag/1.20.0

 - drupal/core-project-message updated from 10.3.5 to 10.3.7 patch
   See changes: https://github.com/drupal/core-project-message/compare/10.3.5...10.3.7
   Release notes: https://github.com/drupal/core-project-message/releases/tag/10.3.7

 - drupal/core-composer-scaffold updated from 10.2.7 to 10.3.6 minor
   See changes: https://github.com/drupal/core-composer-scaffold/compare/10.2.7...10.3.6
   Release notes: https://github.com/drupal/core-composer-scaffold/releases/tag/10.3.6

 - composer/semver updated from 3.4.2 to 3.4.3 patch
   See changes: https://github.com/composer/semver/compare/3.4.2...3.4.3
   Release notes: https://github.com/composer/semver/releases/tag/3.4.3

 - tbachert/spi installed in version v1.0.2
   Release notes: https://github.com/Nevay/spi/releases/tag/v1.0.2

 - ergebnis/json-printer updated from 3.5.0 to 3.6.0 minor
   See changes: https://github.com/ergebnis/json-printer/compare/3.5.0...3.6.0
   Release notes: https://github.com/ergebnis/json-printer/releases/tag/3.6.0

 - ergebnis/json-pointer updated from 3.4.0 to 3.5.0 minor
   See changes: https://github.com/ergebnis/json-pointer/compare/3.4.0...3.5.0
   Release notes: https://github.com/ergebnis/json-pointer/releases/tag/3.5.0

 - ergebnis/json updated from 1.2.0 to 1.3.0 minor
   See changes: https://github.com/ergebnis/json/compare/1.2.0...1.3.0
   Release notes: https://github.com/ergebnis/json/releases/tag/1.3.0

 - ergebnis/json-schema-validator updated from 4.2.0 to 4.3.0 minor
   See changes: https://github.com/ergebnis/json-schema-validator/compare/4.2.0...4.3.0
   Release notes: https://github.com/ergebnis/json-schema-validator/releases/tag/4.3.0

 - ergebnis/json-normalizer updated from 4.5.0 to 4.6.0 minor
   See changes: https://github.com/ergebnis/json-normalizer/compare/4.5.0...4.6.0
   Release notes: https://github.com/ergebnis/json-normalizer/releases/tag/4.6.0

 - ergebnis/composer-normalize updated from 2.43.0 to 2.44.0 minor
   See changes: https://github.com/ergebnis/composer-normalize/compare/2.43.0...2.44.0
   Release notes: https://github.com/ergebnis/composer-normalize/releases/tag/2.44.0

 - symfony/polyfill-ctype updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-ctype/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-ctype/releases/tag/v1.29.0

 - symfony/polyfill-php83 updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-php83/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-php83/releases/tag/v1.29.0

 - symfony/polyfill-mbstring updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-mbstring/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-mbstring/releases/tag/v1.29.0

 - symfony/deprecation-contracts updated from v3.4.0 to v3.5.0 minor
   See changes: https://github.com/symfony/deprecation-contracts/compare/v3.4.0...v3.5.0
   Release notes: https://github.com/symfony/deprecation-contracts/releases/tag/v3.5.0

 - symfony/http-foundation updated from v6.4.10 to v6.4.14 patch
   See changes: https://github.com/symfony/http-foundation/compare/v6.4.10...v6.4.14
   Release notes: https://github.com/symfony/http-foundation/releases/tag/v6.4.14

 - symfony/event-dispatcher-contracts updated from v3.4.2 to v3.5.0 minor
   See changes: https://github.com/symfony/event-dispatcher-contracts/compare/v3.4.2...v3.5.0
   Release notes: https://github.com/symfony/event-dispatcher-contracts/releases/tag/v3.5.0

 - symfony/event-dispatcher updated from v6.4.8 to v6.4.13 patch
   See changes: https://github.com/symfony/event-dispatcher/compare/v6.4.8...v6.4.13
   Release notes: https://github.com/symfony/event-dispatcher/releases/tag/v6.4.13

 - symfony/var-dumper updated from v6.4.11 to v6.4.14 patch
   See changes: https://github.com/symfony/var-dumper/compare/v6.4.11...v6.4.14
   Release notes: https://github.com/symfony/var-dumper/releases/tag/v6.4.14

 - symfony/error-handler updated from v6.4.10 to v6.4.14 patch
   See changes: https://github.com/symfony/error-handler/compare/v6.4.10...v6.4.14
   Release notes: https://github.com/symfony/error-handler/releases/tag/v6.4.14

 - symfony/http-kernel updated from v6.4.11 to v6.4.14 patch
   See changes: https://github.com/symfony/http-kernel/compare/v6.4.11...v6.4.14
   Release notes: https://github.com/symfony/http-kernel/releases/tag/v6.4.14

 - behat/gherkin updated from v4.9.0 to v4.10.0 minor
   See changes: https://github.com/Behat/Gherkin/compare/v4.9.0...v4.10.0
   Release notes: https://github.com/Behat/Gherkin/releases/tag/v4.10.0

 - composer/ca-bundle updated from 1.5.1 to 1.5.3 patch
   See changes: https://github.com/composer/ca-bundle/compare/1.5.1...1.5.3
   Release notes: https://github.com/composer/ca-bundle/releases/tag/1.5.3

 - symfony/finder updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/finder/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/finder/releases/tag/v6.4.13

 - composer/class-map-generator updated from 1.3.4 to 1.4.0 minor
   See changes: https://github.com/composer/class-map-generator/compare/1.3.4...1.4.0
   Release notes: https://github.com/composer/class-map-generator/releases/tag/1.4.0

 - symfony/polyfill-intl-normalizer updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-intl-normalizer/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-intl-normalizer/releases/tag/v1.29.0

 - symfony/polyfill-intl-grapheme updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-intl-grapheme/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-intl-grapheme/releases/tag/v1.29.0

 - symfony/string updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/string/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/string/releases/tag/v6.4.13

 - symfony/service-contracts updated from v3.4.2 to v3.5.0 minor
   See changes: https://github.com/symfony/service-contracts/compare/v3.4.2...v3.5.0
   Release notes: https://github.com/symfony/service-contracts/releases/tag/v3.5.0

 - symfony/console updated from v6.4.11 to v6.4.14 patch
   See changes: https://github.com/symfony/console/compare/v6.4.11...v6.4.14
   Release notes: https://github.com/symfony/console/releases/tag/v6.4.14

 - symfony/filesystem updated from v6.4.9 to v6.4.13 patch
   See changes: https://github.com/symfony/filesystem/compare/v6.4.9...v6.4.13
   Release notes: https://github.com/symfony/filesystem/releases/tag/v6.4.13

 - doctrine/persistence updated from 3.3.3 to 3.4.0 minor
   See changes: https://github.com/doctrine/persistence/compare/3.3.3...3.4.0
   Release notes: https://github.com/doctrine/persistence/releases/tag/3.4.0

 - doctrine/common updated from 3.4.4 to 3.4.5 patch
   See changes: https://github.com/doctrine/common/compare/3.4.4...3.4.5
   Release notes: https://github.com/doctrine/common/releases/tag/3.4.5

 - symfony/yaml updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/yaml/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/yaml/releases/tag/v6.4.13

 - symfony/translation-contracts updated from v3.4.2 to v3.5.0 minor
   See changes: https://github.com/symfony/translation-contracts/compare/v3.4.2...v3.5.0
   Release notes: https://github.com/symfony/translation-contracts/releases/tag/v3.5.0

 - symfony/translation updated from v7.1.3 to v7.1.6 patch
   See changes: https://github.com/symfony/translation/compare/v7.1.3...v7.1.6
   Release notes: https://github.com/symfony/translation/releases/tag/v7.1.6

 - symfony/var-exporter updated from v6.4.9 to v6.4.13 patch
   See changes: https://github.com/symfony/var-exporter/compare/v6.4.9...v6.4.13
   Release notes: https://github.com/symfony/var-exporter/releases/tag/v6.4.13

 - symfony/dependency-injection updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/dependency-injection/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/dependency-injection/releases/tag/v6.4.13

 - behat/behat updated from v3.14.0 to v3.15.0 minor
   See changes: https://github.com/Behat/Behat/compare/v3.14.0...v3.15.0
   Release notes: https://github.com/Behat/Behat/releases/tag/v3.15.0

 - symfony/http-client updated from v6.4.11 to v6.4.14 patch
   See changes: https://github.com/symfony/http-client/compare/v6.4.11...v6.4.14
   Release notes: https://github.com/symfony/http-client/releases/tag/v6.4.14

 - symfony/css-selector updated from v6.4.8 to v6.4.13 patch
   See changes: https://github.com/symfony/css-selector/compare/v6.4.8...v6.4.13
   Release notes: https://github.com/symfony/css-selector/releases/tag/v6.4.13

 - drevops/behat-screenshot updated from 1.5.0 to 1.6.0 minor
   See changes: https://github.com/drevops/behat-screenshot/compare/1.5.0...1.6.0
   Release notes: https://github.com/drevops/behat-screenshot/releases/tag/1.6.0

 - symfony/process updated from v6.4.8 to v6.4.14 patch
   See changes: https://github.com/symfony/process/compare/v6.4.8...v6.4.14
   Release notes: https://github.com/symfony/process/releases/tag/v6.4.14

 - twig/twig updated from v3.8.0 to v3.14.2 minor
   See changes: https://github.com/twigphp/Twig/compare/v3.8.0...v3.14.2
   Release notes: https://github.com/twigphp/Twig/releases/tag/v3.14.2

 - symfony/validator updated from v6.4.11 to v6.4.14 patch
   See changes: https://github.com/symfony/validator/compare/v6.4.11...v6.4.14
   Release notes: https://github.com/symfony/validator/releases/tag/v6.4.14

 - symfony/serializer updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/serializer/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/serializer/releases/tag/v6.4.13

 - symfony/routing updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/routing/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/routing/releases/tag/v6.4.13

 - symfony/psr-http-message-bridge updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/psr-http-message-bridge/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/psr-http-message-bridge/releases/tag/v6.4.13

 - symfony/polyfill-iconv updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-iconv/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-iconv/releases/tag/v1.29.0

 - symfony/polyfill-intl-idn updated from v1.28.0 to v1.29.0 minor
   See changes: https://github.com/symfony/polyfill-intl-idn/compare/v1.28.0...v1.29.0
   Release notes: https://github.com/symfony/polyfill-intl-idn/releases/tag/v1.29.0

 - symfony/mime updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/mime/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/mime/releases/tag/v6.4.13

 - symfony/mailer updated from v6.4.9 to v6.4.13 patch
   See changes: https://github.com/symfony/mailer/compare/v6.4.9...v6.4.13
   Release notes: https://github.com/symfony/mailer/releases/tag/v6.4.13

 - pear/archive_tar updated from 1.4.14 to 1.5.0 minor
   See changes: https://github.com/pear/Archive_Tar/compare/1.4.14...1.5.0
   Release notes: https://github.com/pear/Archive_Tar/releases/tag/1.5.0

 - mck89/peast updated from v1.15.4 to v1.16.3 minor
   See changes: https://github.com/mck89/peast/compare/v1.15.4...v1.16.3
   Release notes: https://github.com/mck89/peast/releases/tag/v1.16.3

 - masterminds/html5 updated from 2.8.1 to 2.9.0 minor
   See changes: https://github.com/Masterminds/html5-php/compare/2.8.1...2.9.0
   Release notes: https://github.com/Masterminds/html5-php/releases/tag/2.9.0

 - psr/http-factory updated from 1.0.2 to 1.1.0 minor
   See changes: https://github.com/php-fig/http-factory/compare/1.0.2...1.1.0
   Release notes: https://github.com/php-fig/http-factory/releases/tag/1.1.0

 - guzzlehttp/promises updated from 2.0.3 to 2.0.4 patch
   See changes: https://github.com/guzzle/promises/compare/2.0.3...2.0.4
   Release notes: https://github.com/guzzle/promises/releases/tag/2.0.4

 - drupal/core updated from 10.2.7 to 10.3.6 minor
   See changes: https://github.com/drupal/core/compare/10.2.7...10.3.6
   Release notes: https://github.com/drupal/core/releases/tag/10.3.6

 - drupal/drupal-driver updated from v2.2.2 to v2.3.0 minor
   See changes: https://github.com/jhedstrom/DrupalDriver/compare/v2.2.2...v2.3.0
   Release notes: https://github.com/jhedstrom/DrupalDriver/releases/tag/v2.3.0

 - symfony/dom-crawler updated from v6.4.8 to v6.4.13 patch
   See changes: https://github.com/symfony/dom-crawler/compare/v6.4.8...v6.4.13
   Release notes: https://github.com/symfony/dom-crawler/releases/tag/v6.4.13

 - symfony/browser-kit updated from v6.4.8 to v6.4.13 patch
   See changes: https://github.com/symfony/browser-kit/compare/v6.4.8...v6.4.13
   Release notes: https://github.com/symfony/browser-kit/releases/tag/v6.4.13

 - drupal/drupal-extension updated from v5.0.0 to v5.1.0 minor
   See changes: https://github.com/jhedstrom/drupalextension/compare/v5.0.0...v5.1.0
   Release notes: https://github.com/jhedstrom/drupalextension/releases/tag/v5.1.0

 - drupal/chosen updated from 4.0.1 to 4.0.3 patch

 - drupal/config_devel updated from 1.9.0 to 1.10.0 minor

 - symfony/phpunit-bridge updated from v6.4.11 to v6.4.13 patch
   See changes: https://github.com/symfony/phpunit-bridge/compare/v6.4.11...v6.4.13
   Release notes: https://github.com/symfony/phpunit-bridge/releases/tag/v6.4.13

 - symfony/lock updated from v6.4.8 to v6.4.13 patch
   See changes: https://github.com/symfony/lock/compare/v6.4.8...v6.4.13
   Release notes: https://github.com/symfony/lock/releases/tag/v6.4.13

 - nikic/php-parser updated from v5.2.0 to v5.3.1 minor
   See changes: https://github.com/nikic/PHP-Parser/compare/v5.2.0...v5.3.1
   Release notes: https://github.com/nikic/PHP-Parser/releases/tag/v5.3.1

 - phpunit/phpunit updated from 9.6.20 to 9.6.21 patch
   See changes: https://github.com/sebastianbergmann/phpunit/compare/9.6.20...9.6.21
   Release notes: https://github.com/sebastianbergmann/phpunit/releases/tag/9.6.21

 - phpstan/phpstan updated from 1.12.3 to 1.12.8 patch
   See changes: https://github.com/phpstan/phpstan/compare/1.12.3...1.12.8
   Release notes: https://github.com/phpstan/phpstan/releases/tag/1.12.8

 - phpstan/phpdoc-parser updated from 1.30.1 to 1.33.0 minor
   See changes: https://github.com/phpstan/phpdoc-parser/compare/1.30.1...1.33.0
   Release notes: https://github.com/phpstan/phpdoc-parser/releases/tag/1.33.0

 - phpdocumentor/type-resolver updated from 1.8.2 to 1.9.0 minor
   See changes: https://github.com/phpDocumentor/TypeResolver/compare/1.8.2...1.9.0
   Release notes: https://github.com/phpDocumentor/TypeResolver/releases/tag/1.9.0

 - phpdocumentor/reflection-docblock updated from 5.4.1 to 5.5.1 minor
   See changes: https://github.com/phpDocumentor/ReflectionDocBlock/compare/5.4.1...5.5.1
   Release notes: https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.5.1

 - php-http/httplug updated from 2.4.0 to 2.4.1 patch
   See changes: https://github.com/php-http/httplug/compare/2.4.0...2.4.1
   Release notes: https://github.com/php-http/httplug/releases/tag/2.4.1

 - ramsey/collection installed in version 2.0.0
   Release notes: https://github.com/ramsey/collection/releases/tag/2.0.0

 - brick/math installed in version 0.12.1
   Release notes: https://github.com/brick/math/releases/tag/0.12.1

 - ramsey/uuid installed in version 4.7.6
   Release notes: https://github.com/ramsey/uuid/releases/tag/4.7.6

 - open-telemetry/context updated from 1.0.2 to 1.1.0 minor
   See changes: https://github.com/opentelemetry-php/context/compare/1.0.2...1.1.0
   Release notes: https://github.com/opentelemetry-php/context/releases/tag/1.1.0

 - open-telemetry/api updated from 1.0.3 to 1.1.1 minor
   See changes: https://github.com/opentelemetry-php/api/compare/1.0.3...1.1.1
   Release notes: https://github.com/opentelemetry-php/api/releases/tag/1.1.1

 - nyholm/psr7-server installed in version 1.1.0
   Release notes: https://github.com/Nyholm/psr7-server/releases/tag/1.1.0

 - open-telemetry/sdk updated from 1.0.8 to 1.1.2 minor
   See changes: https://github.com/opentelemetry-php/sdk/compare/1.0.8...1.1.2
   Release notes: https://github.com/opentelemetry-php/sdk/releases/tag/1.1.2

 - google/protobuf updated from v3.25.5 to v4.28.3 major
   See changes: https://github.com/protocolbuffers/protobuf-php/compare/v3.25.5...v4.28.3
   Release notes: https://github.com/protocolbuffers/protobuf-php/releases/tag/v4.28.3

 - open-telemetry/gen-otlp-protobuf updated from 1.2.0 to 1.2.1 patch
   See changes: https://github.com/opentelemetry-php/gen-otlp-protobuf/compare/1.2.0...1.2.1
   Release notes: https://github.com/opentelemetry-php/gen-otlp-protobuf/releases/tag/1.2.1

 - open-telemetry/exporter-otlp updated from 1.0.4 to 1.1.0 minor
   See changes: https://github.com/opentelemetry-php/exporter-otlp/compare/1.0.4...1.1.0
   Release notes: https://github.com/opentelemetry-php/exporter-otlp/releases/tag/1.1.0

 - mglaman/phpstan-drupal installed in version 1.3.1
   Release notes: https://github.com/mglaman/phpstan-drupal/releases/tag/1.3.1

 - drupal/coder updated from 8.3.24 to 8.3.25 patch
   See changes: https://github.com/pfrenssen/coder/compare/8.3.24...8.3.25
   Release notes: https://github.com/pfrenssen/coder/releases/tag/8.3.25

 - composer/composer updated from 2.7.9 to 2.8.2 minor
   See changes: https://github.com/composer/composer/compare/2.7.9...2.8.2
   Release notes: https://github.com/composer/composer/releases/tag/2.8.2

 - drupal/core-dev updated from 10.2.8 to 10.2.10 patch
   See changes: https://github.com/drupal/core-dev/compare/10.2.8...10.2.10
   Release notes: https://github.com/drupal/core-dev/releases/tag/10.2.10

 - doctrine/dbal updated from 3.9.1 to 3.9.3 patch
   See changes: https://github.com/doctrine/dbal/compare/3.9.1...3.9.3
   Release notes: https://github.com/doctrine/dbal/releases/tag/3.9.3

 - league/container updated from 4.2.2 to 4.2.3 patch
   See changes: https://github.com/thephpleague/container/compare/4.2.2...4.2.3
   Release notes: https://github.com/thephpleague/container/releases/tag/4.2.3

 - phootwork/lang updated from v3.2.2 to v3.2.3 patch
   See changes: https://github.com/phootwork/lang/compare/v3.2.2...v3.2.3
   Release notes: https://github.com/phootwork/lang/releases/tag/v3.2.3

 - phootwork/collection updated from v3.2.2 to v3.2.3 patch
   See changes: https://github.com/phootwork/collection/compare/v3.2.2...v3.2.3
   Release notes: https://github.com/phootwork/collection/releases/tag/v3.2.3

 - consolidation/output-formatters updated from 4.5.0 to 4.6.0 minor
   See changes: https://github.com/consolidation/output-formatters/compare/4.5.0...4.6.0
   Release notes: https://github.com/consolidation/output-formatters/releases/tag/4.6.0

 - ezyang/htmlpurifier updated from v4.17.0 to v4.18.0 minor
   See changes: https://github.com/ezyang/htmlpurifier/compare/v4.17.0...v4.18.0
   Release notes: https://github.com/ezyang/htmlpurifier/releases/tag/v4.18.0

 - drupal/username_enumeration_prevention updated from 1.3.0 to 1.4.0 minor

 - drupal/encrypt updated from 3.1.0 to 3.2.0 minor

 - drupal/tfa updated from 1.7.0 to 1.8.0 minor

 - drupal/simple_sitemap updated from 4.1.9 to 4.2.1 minor

 - lcobucci/clock updated from 3.2.0 to 3.3.1 minor
   See changes: https://github.com/lcobucci/clock/compare/3.2.0...3.3.1
   Release notes: https://github.com/lcobucci/clock/releases/tag/3.3.1

 - drupal/seckit updated from 2.0.1 to 2.0.3 patch

 - maennchen/zipstream-php updated from 3.1.0 to 3.1.1 patch
   See changes: https://github.com/maennchen/ZipStream-PHP/compare/3.1.0...3.1.1
   Release notes: https://github.com/maennchen/ZipStream-PHP/releases/tag/3.1.1

 - laminas/laminas-stdlib updated from 3.19.0 to 3.20.0 minor
   See changes: https://github.com/laminas/laminas-stdlib/compare/3.19.0...3.20.0
   Release notes: https://github.com/laminas/laminas-stdlib/releases/tag/3.20.0

 - drupal/role_delegation updated from 1.2.0 to 1.3.0 minor

 - drupal/robotstxt updated from 1.5.0 to 1.6.0 minor

 - drupal/rest_menu_items updated from 3.0.3 to 3.0.4 patch

 - drupal/redirect updated from 1.9.0 to 1.10.0 minor

 - drupal/recaptcha_v3 updated from 2.0.2 to 2.0.3 patch

 - drupal/recaptcha updated from 3.3.0 to 3.4.0 minor

 - drupal/pathauto updated from 1.12.0 to 1.13.0 minor

 - drupal/password_policy updated from 4.0.1 to 4.0.3 patch

 - drupal/entity_reference_revisions updated from 1.11.0 to 1.12.0 minor

 - drupal/paragraphs updated from 1.17.0 to 1.18.0 minor

 - drupal/minisite updated from 2.2.0 to 2.3.0 minor

 - league/csv updated from 9.16.0 to 9.18.0 minor
   See changes: https://github.com/thephpleague/csv/compare/9.16.0...9.18.0
   Release notes: https://github.com/thephpleague/csv/releases/tag/9.18.0

 - drupal/metatag updated from 2.0.0 to 2.0.2 patch

 - drupal/menu_trail_by_path updated from 2.0.1 to 2.1.0 minor

 - drupal/menu_block updated from 1.11.0 to 1.13.0 minor

 - drupal/media_entity_file_replace updated from 1.2.0 to 1.3.0 minor

 - drupal/dropzonejs updated from 2.10.0 to 2.11.0 minor

 - drupal/mailsystem updated from 4.4.0 to 4.5.0 minor

 - drupal/login_security updated from 2.0.1 to 2.0.2 patch

 - drupal/honeypot updated from 2.1.3 to 2.1.4 patch

 - drupal/file_to_media updated from 1.0.2 to 1.0.3 patch

 - drupal/field_group updated from 3.4.0 to 3.6.0 minor

 - drupal/facets updated from 2.0.7 to 2.0.9 patch

 - drupal/entity_reference_display updated from 2.0.0 to 2.0.2 patch

 - drupal/embed updated from 1.7.0 to 1.9.0 minor

 - drupal/entity_class_formatter updated from 2.0.0 to 2.0.1 patch

 - drupal/entity_browser updated from 2.10.0 to 2.11.0 minor

 - drupal/ds updated from 3.22.0 to 3.24.0 minor

 - drupal/diff updated from 1.7.0 to 1.8.0 minor

 - drupal/core-recommended updated from 10.2.7 to 10.3.6 minor
   See changes: https://github.com/drupal/core-recommended/compare/10.2.7...10.3.6
   Release notes: https://github.com/drupal/core-recommended/releases/tag/10.3.6

 - drupal/contact_storage updated from 1.3.0 to 1.4.0 minor

 - drupal/config_update updated from 2.0.0-alpha3 to 2.0.0-alpha4 patch

 - drupal/config_filter updated from 2.6.0 to 2.7.0 minor

 - drupal/components updated from 3.0.0-beta3 to 3.1.0 minor

 - drupal/admin_toolbar updated from 3.4.2 to 3.5.0 minor

 - govcms/govcms updated from 3.16.0 to 3.19.0 minor
   See changes: https://github.com/govCMS/GovCMS/compare/3.16.0...3.19.0
   Release notes: https://github.com/govCMS/GovCMS/releases/tag/3.19.0

 - rector/rector updated from 1.2.5 to 1.2.9 patch
   See changes: https://github.com/rectorphp/rector/compare/1.2.5...1.2.9
   Release notes: https://github.com/rectorphp/rector/releases/tag/1.2.9

.circleci/config.yml

richardgaunt

Thanks @joshua-salsadigital updated config and got build working

#3475110 Fixed FileSystemInterface replace behaviour constants deprec…

5d5a4f7

…ated and replaced with an enum.

joshua-salsadigital self-assigned this Oct 28, 2024

#3475110 Fixed FileSystemInterface replace behaviour constants deprec…

44499fb

…ated and replaced with an enum.

joshua-salsadigital requested a review from richardgaunt October 28, 2024 08:56

joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Oct 28, 2024

Joshua Fernandes added 6 commits October 28, 2024 20:08

Updated packages and modules and govcms to latest to test issue.

e304745

Updated packages and modules and govcms to latest to test issue.

96dc863

Merge branch 'develop' into feature/3475110-depricated-fixes

3382565

Updated Drupal to 10.3 with all dependencies.

4556ee6

Updated PHP to 8.3

3a00e76

Disabled from CI

0fe4ea0

build-isolated-php-84 build-isolated-php-84-next

joshua-salsadigital commented Nov 8, 2024

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

Joshua Fernandes and others added 9 commits November 8, 2024 12:18

Lint error fixes.

f7a1074

Lint fixes.

e686598

Fixed failing behat test.

3cbbbaa

Merge branch 'develop' into feature/3475110-depricated-fixes

f3a742c

Merge branch 'develop' into feature/3475110-depricated-fixes

7fbde6d

Lint fixes.

bf69076

Update theme config for 10.3 updates.

c75c1f8

Lint fix.

0a9d0c2

Update region placement of date field.

4848985

richardgaunt force-pushed the feature/3475110-depricated-fixes branch from 4825cd5 to 4848985 Compare November 23, 2024 23:47

richardgaunt added 3 commits November 24, 2024 10:54

Update default region for three col layout.

bccc24e

More config changes.

2aea6ce

Further updates to config.

265c4f2

richardgaunt approved these changes Nov 24, 2024

View reviewed changes

richardgaunt force-pushed the feature/3475110-depricated-fixes branch 4 times, most recently from 8b29253 to b9dcb0c Compare November 24, 2024 02:21

Add back one build for php8.2.

be0b2bf

richardgaunt force-pushed the feature/3475110-depricated-fixes branch from b9dcb0c to be0b2bf Compare November 24, 2024 02:32

richardgaunt merged commit 3fa27f6 into develop Nov 24, 2024
12 checks passed

richardgaunt deleted the feature/3475110-depricated-fixes branch November 24, 2024 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #3475110 by joshua1234511, richardgaunt, sime, granticusiv: Illegal access to constants in shipshape on govcms #1314

Issue #3475110 by joshua1234511, richardgaunt, sime, granticusiv: Illegal access to constants in shipshape on govcms #1314

joshua-salsadigital commented Oct 28, 2024 •

edited

Loading

joshua-salsadigital commented Oct 28, 2024 •

edited

Loading

joshua-salsadigital commented Oct 28, 2024

joshua-salsadigital commented Oct 28, 2024

joshua-salsadigital commented Nov 8, 2024

richardgaunt left a comment

Issue #3475110 by joshua1234511, richardgaunt, sime, granticusiv: Illegal access to constants in shipshape on govcms #1314

Issue #3475110 by joshua1234511, richardgaunt, sime, granticusiv: Illegal access to constants in shipshape on govcms #1314

Conversation

joshua-salsadigital commented Oct 28, 2024 • edited Loading

Checklist before requesting a review

Changed

Screenshots

joshua-salsadigital commented Oct 28, 2024 • edited Loading

joshua-salsadigital commented Oct 28, 2024

joshua-salsadigital commented Oct 28, 2024

joshua-salsadigital commented Nov 8, 2024

richardgaunt left a comment

Choose a reason for hiding this comment

joshua-salsadigital commented Oct 28, 2024 •

edited

Loading

joshua-salsadigital commented Oct 28, 2024 •

edited

Loading