Add support for type string with format binary #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbooms
reviewed
Aug 31, 2023
| @@ -0,0 +1,24 @@ | |||
| openapi: 3.0.1 | |||
There was a problem hiding this comment.
could we tack this example on to an existing test case rather than creating a new example?
By just adding an additional format binary property to one single test case
There was a problem hiding this comment.
Sure, which one do you want it added to? From what I can see there are 5 files that currently generate controller code for both spring and micronaut:
- githubApi
- singleAllOf
- authentication
- parameterNameClash
- pathLevelParameters
Based on that I don't think it really fits anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now trying to specify a schema like
{"type": "string", "format": "binary"}falls back tokotlin.String.The binary format is one of the string formats defined by the openapi specification, used mostly for describing endpoints accepting/returning files.
The last commit is actually optional.
JsonOverlayencodes/as~1before joining the path together with/, which leads to a strange to read parameter name likeapplication1octetStream.