Fix: Remove duplicate classes in nested polymorphic models #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filters the models in groupClasses again, to make sure no sealed classes are generated multiple times. GroupClasses was adding the child class to the superclass, even though it created it's own class again because it's sealed and has children.
|
Perhaps the test for models with the single file output could be deleted with this new test |
Yes, I think this is a good idea. Let's do that as a precursor PR so we can both see the problem you have found and fix you have provided. Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #281 for detailed explanation
this also adds a test which compares the created model files (individual model files) to the generated files, to check for differences.
the changes in KotlinGenModels doesn't introduce changes in any other api files apart from the nestedPolymorphicModel file
Sorry for creating this many files, i wanted to make sure my changes didn't cause any regressions in the model generation of other api files