Adds an option to generate spring controllers that return CompletableFutures #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbooms
reviewed
Jul 29, 2024
| @@ -41,6 +43,8 @@ object SpringImports { | |||
|
|
|||
| val AUTHENTICATION = ClassName(Packages.SPRING_AUTHENTICATION, "Authentication") | |||
|
|
|||
| val COMPLETABLE_FUTURE = ClassName(Packages.JAVA_UTIL_CONCURRENT, "CompletableFuture") | |||
There was a problem hiding this comment.
Would the interface be better? eg CompletionStage
There was a problem hiding this comment.
Probably cleaner, although there is nothing else in the jdk the extends the interface.
…tage change to CompletionStage
zettelmj
force-pushed
the
add_spring_controller_functions_completable_future
branch
from
5e8e8bf to
fada4d1
Compare
|
👍 |
|
LGTM, just need to regenerate and update the able in the README. |
I don't need it, I just got asked how to configure fabrikt so that CompletableFutures are returned. Since I had the time it felt like a useful addition. |
cjbooms
approved these changes
Jul 29, 2024
ulrikandersen
deleted the
add_spring_controller_functions_completable_future
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to generate spring controllers that return CompletableFutures