Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume for pip cache, keep volumes #143

Merged
merged 1 commit into from
Apr 30, 2024
+11 −4
Merged

volume for pip cache, keep volumes #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ volumes:
ckan_storage:
pg_data:
solr_data:
pip_cache:
site_packages:
vscode_server:

services:

Expand All @@ -22,12 +25,13 @@ services:
volumes:
- ckan_storage:/var/lib/ckan
- ./src:/srv/app/src_extensions
- /usr/lib/python3.10/site-packages
- /root/.vscode-server
- pip_cache:/root/.cache/pip
- site_packages:/usr/lib/python3.10/site-packages
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually going to work?

This isn't going to be live at build time, so your install is going to go into the image. Presumably, this will initialize the volume with the contents of the directory when first run, but then if you rebuild the image, the site-packages are going to be out of date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup script re-installs everything so if you have an out of date volume locally and upgrade ckan versions it should only dowload and re-install once.

- vscode_server:/root/.vscode-server
restart: unless-stopped
healthcheck:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:5000"]

datapusher:
image: ckan/ckan-base-datapusher:${DATAPUSHER_VERSION}
restart: unless-stopped
Expand Down
5 changes: 4 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ volumes:
ckan_storage:
pg_data:
solr_data:
pip_cache:
site_packages:

services:

Expand Down Expand Up @@ -40,7 +42,8 @@ services:
condition: service_healthy
volumes:
- ckan_storage:/var/lib/ckan
- /usr/lib/python3.10/site-packages
- pip_cache:/root/.cache/pip
- site_packages:/usr/lib/python3.10/site-packages
restart: unless-stopped
healthcheck:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:5000"]
Expand Down
Loading