-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves URI from contact point #312
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf30687
Solves URI from contact point
6f4628b
Apply review comments
1702e7e
Add UT contact point identifier
d403d23
Merge commit 'e760188875dd6bc821a009756613313a5690a2fe' into solves-u…
448c311
revert back deletion
b47f389
Keep this part as it is
41ab477
add contact contact indentifier to mapping
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -706,6 +706,7 @@ def test_contact_details(self): | |
<vcard:Organization> | ||
<vcard:fn>Point of Contact</vcard:fn> | ||
<vcard:hasEmail rdf:resource="mailto:[email protected]"/> | ||
<vcard:hasUID rdf:resource="https://orcid.org/0000-0002-9095-9201"/> | ||
</vcard:Organization> | ||
</adms:contactPoint> | ||
</rdfs:SomeClass> | ||
|
@@ -723,3 +724,5 @@ def test_contact_details(self): | |
assert contact['name'] == 'Point of Contact' | ||
# mailto gets removed for storage and is added again on output | ||
assert contact['email'] == '[email protected]' | ||
|
||
assert contact['identifier'] == 'https://orcid.org/0000-0002-9095-9201' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,11 +52,13 @@ | |
"contact": [ | ||
{ | ||
"name": "Contact 1", | ||
"email": "[email protected]" | ||
"email": "[email protected]", | ||
"identifier": "123" | ||
}, | ||
{ | ||
"name": "Contact 2", | ||
"email": "[email protected]" | ||
"email": "[email protected]", | ||
"identifier": "456" | ||
} | ||
], | ||
"creator": [ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this as it was and not assign hasUID to
uri
as discussed.Otherwise this is good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted this part back and added also the new mapping to the documentation