Update tests for changes in date parsing in new rdflib versions #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rdflib 7.1 introduced changes in [date parsing][1] that made some base
profile tests fail. Basically the previous rdflib versions incomplete
dates like
<time:inXSDDateTimeStamp
rdf:datatype="http://www.w3.org/2001/XMLSchema#date">
1904
</time:inXSDDateTimeStamp>
were expanded to `1904-01-01`. Of course this is not a valid date and
should be expressed using `gYear`:
<time:inXSDDateTimeStamp
rdf:datatype="http://www.w3.org/2001/XMLSchema#gYear">
1904
</time:inXSDDateTimeStamp>
and we should be expecting `1904`.
This should play nice with the time properties we are generating in CKAN as
they already handle automatically `gYear`, `gYearMonth`, `date` and
`dateTime`.
Sites importing external DCAT representations that use the wrong
encoding might need to check their parsers.
[1] RDFLib/rdflib#2929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rdflib 7.1.0 introduced changes in [date parsing][1] that made some base profile tests fail. Basically the previous rdflib versions incomplete dates like
were expanded to
1904-01-01. Of course this is not a valid date and should be expressed usinggYear:and we should be expecting
1904.This should play nice with the time properties we are generating in CKAN as they already handle automatically
gYear,gYearMonth,dateanddateTime.Sites importing external DCAT representations that use the wrong encoding might need to check their parsers.
[1] RDFLib/rdflib#2929