Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit table schema using CKAN Schema Creator #34

Closed
2 tasks done
roll opened this issue Apr 10, 2018 · 2 comments
Closed
2 tasks done

Allow to edit table schema using CKAN Schema Creator #34

roll opened this issue Apr 10, 2018 · 2 comments
Assignees

Comments

@roll
Copy link
Contributor

roll commented Apr 10, 2018

Current

After #25 the user is able to infer a schema based on the provided data file:

Step 1

After uploading the file we show Infer

ckan1

Step 2

After clicking on the Infer above (a modal window)

ckan2

Step 3

After clicking on the Save above

ckan3

Improvements

But we'd like to provide also an ability to edit already loaded/inferred schema. UI could be like this (an Edit button could be something like Open Editor etc):

ckan4


ckan5

After a click on the Edit button we back to the scenario above starting from the Step 2.

The tableschemaUI.EditorSchema fully supports stand-alone schema editing we just need to provide schema as a part of props instead of source as we do for the inferring.

Tasks

  • implement the described improvements
  • ensure that resource editing works as expected
@amercader
Copy link
Member

This all sounds brilliant @roll. The only thing I'm not sure about is the last bit about allowing to edit a linked schema. Right now the extension does not store remote schemas to allow these to be maintained separately. If users want to edit it they can download it and upload it.

@roll roll self-assigned this Apr 11, 2018
@roll
Copy link
Contributor Author

roll commented Apr 13, 2018

Fixes in #25

@roll roll closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants