-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema editor integration #25
base: master
Are you sure you want to change the base?
Conversation
1 similar comment
@amercader
|
Known issues
|
@amercader I've made the user control flow changes we've discussed (an issue for the schema editing - #34). A few things which are not resolved (please help if you can):
|
@@ -98,18 +127,41 @@ this.ckan.module('resource-schema', function($) { | |||
.on('click', this._onRemoveURL) | |||
.insertBefore(this.field_url_input); | |||
|
|||
// TODO: disable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amercader
Can you please take a look how it works now?
TBH I feel like I'm missing something regarding your comment here - #34 (comment). And because of the bad sound quality haven't got fully your explanation during our call.
Of course, I'm pretty neutral on enabling/disabling the linked schema editing - just curious why the user can't edit the linked schema based on the same approach we have for the create resource page.
@amercader Have we integrated it already? |
QOL-9055 Add Python 3 compatibility and continuous integration testing
Control flow
#field-schema[-url]/[-json]
changestableschemaUI.EditorSchema
with url/File/text as descriptor andonSave
callbacktableschemaUI.EditorSchema
save click the component callsonSave(descriptor)
descriptor
to#field-schema
valueRelated