Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: deploy defaults to data1 #710

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Jun 11, 2024

Description

This PR changes the default hash_type of generateDeployWithDataTx to data1 since data2 is not active on the testnet or mainnet yet

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@homura homura requested a review from Keith-CY June 11, 2024 03:14
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 9:36am

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (8d11c75) to head (1ffea89).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #710      +/-   ##
===========================================
+ Coverage    85.67%   87.80%   +2.13%     
===========================================
  Files          131      131              
  Lines        25247    25231      -16     
  Branches      2663     2796     +133     
===========================================
+ Hits         21631    22155     +524     
+ Misses        3576     3039     -537     
+ Partials        40       37       -3     
Files Coverage Δ
packages/common-scripts/src/deploy.ts 88.17% <100.00%> (-0.31%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d11c75...1ffea89. Read the comment docs.

@Keith-CY
Copy link
Member

This update should be treated as a breaking change because the default value changes.

@homura homura changed the title fix(common-scripts): deploy defaults to data1 BREAKING CHANGE: deploy defaults to data1 Jun 13, 2024
@homura homura merged commit 43a7bc7 into develop Jun 13, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@homura homura deleted the default-data1-deploy branch June 13, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants