Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common-scripts): support eth displaying for omnilock #718

Merged
merged 8 commits into from
Jun 24, 2024

fix(common-scripts): parity check failed

58905f9
Select commit
Loading
Failed to load commit list.
Merged

feat(common-scripts): support eth displaying for omnilock #718

fix(common-scripts): parity check failed
58905f9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 24, 2024 in 0s

85.76% (-1.36%) compared to f2f5666

View this Pull Request on Codecov

85.76% (-1.36%) compared to f2f5666

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (f2f5666) to head (58905f9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #718      +/-   ##
===========================================
- Coverage    87.11%   85.76%   -1.36%     
===========================================
  Files          131      132       +1     
  Lines        25286    25346      +60     
  Branches      2746     2674      -72     
===========================================
- Hits         22027    21737     -290     
- Misses        3219     3569     +350     
  Partials        40       40              
Files Coverage Δ
...common-scripts/src/omnilock-ethereum-displaying.ts 100.00% <100.00%> (ø)
packages/common-scripts/src/omnilock.ts 91.73% <100.00%> (+0.28%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f5666...58905f9. Read the comment docs.