Select all columns in previous table rows when the last row is fully selected. #17697
+75
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (table): Improve selection of the cells with
colspan
attribute. Closes #17538MINOR BREAKING CHANGE (table): The
TableSelection#getSelectedTableCells
method now considers cells with acolspan
. If the selection ends on a cell with acolspan
, it will be adjusted to the end of that cell, and all cells above it will be returned, instead of just one.MINOR BREAKING CHANGE (table): The
TableSelection#setCellSelection
method has been updated to behave consistently with the updatedgetSelectedTableCells
, ensuring that cell selection is aligned with the new behavior regarding cells with acolspan
.Additional information
I normalized cell-span selection behaviour to make it work in similar way it works in TinyMCE.
Before
before-fix-selection-v3-2024-12-30_13.21.34.mp4
before-selection-fix-2024-12-30_10.40.55.mp4
After
after-fix-selection-v3-2024-12-30_13.19.51.mp4
after-fix-selection-2024-12-30_13.17.30.mp4