Add EmptyBlock plugin that prevents adding in exported data.
#17756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mati365
changed the title
EmptyBlocks plugin that allows for preserving empty block elements in the editor.EmptyBlocks plugin that prevents adding in exported data.
niegowski
requested changes
Jan 16, 2025
Mati365
force-pushed
the
ck/skip-block-filler-option
branch
from
b1e0b3b to
e57d7f5
Compare
|
Please link to API docs of this plugin in the table: Mention from which version available. |
niegowski
requested changes
Jan 17, 2025
packages/ckeditor5-table/src/converters/table-cell-paragraph-post-fixer.ts
Outdated
Show resolved
Hide resolved
niegowski
requested changes
Jan 20, 2025
| '<paragraph htmlEmptyBlock="true" listIndent="0" listType="bulleted"></paragraph>' | ||
| ); | ||
|
|
||
| expect( editor.getData() ).to.equal( '<p>A</p><ul><li><p></p></li></ul>' ); |
There was a problem hiding this comment.
I'd expect the output would not have an empty <p> as there wasn't one in the input.
gorzelinski
previously approved these changes
Jan 28, 2025
mmotyczynska
previously approved these changes
Jan 28, 2025
|
@niegowski Can you check? Merging is blocked without your approval. |
Mati365
dismissed stale reviews from gorzelinski, mmotyczynska, and pszczesniak
via
d8cafb7
gorzelinski
previously approved these changes
Jan 30, 2025
niegowski
requested changes
Jan 31, 2025
|
@niegowski CR remarks applied. |
niegowski
requested changes
Jan 31, 2025
packages/ckeditor5-html-support/src/generalhtmlsupportconfig.ts
Outdated
Show resolved
Hide resolved
|
@niegowski CR remarks applied. |
niegowski
reviewed
Jan 31, 2025
| @@ -80,4 +80,21 @@ export interface GeneralHtmlSupportConfig { | |||
| * ``` | |||
| */ | |||
| allowEmpty?: Array<string>; | |||
|
|
|||
| /** | |||
| * Whether a filler text (non-breaking space entity — ) will be inserted into empty block elements in HTML output. | |||
There was a problem hiding this comment.
Suggested change
| * Whether a filler text (non-breaking space entity — ) will be inserted into empty block elements in HTML output. | |
| * Whether a filler text (non-breaking space entity — ` `) will be inserted into empty block elements in HTML output. |
There was a problem hiding this comment.
@Witoso could you check if this config description is clear enough? Note that the feature is enabled by including the plugin itself and this config refers to the alternative mode in the editing pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (html-support): Add an experimental
EmptyBlockplugin that prevents adding to output data.Other (engine): The whitespaces around a block filler (
) are ignored while loading editor data.Additional information
It's part of https://github.com/cksource/ckeditor5-commercial/pull/6942
Original issue https://github.com/cksource/ckeditor5-commercial/issues/6941
More details: Notion