Fix: Nested editable on Safari. #17809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorzelinski
requested review from
arkflpc,
Mati365 and
niegowski
and removed request for
Mati365
gorzelinski
commented
Jan 24, 2025
| // Handle Backspace key while inside a nested editable on Safari. See #17383. | ||
| this.listenTo<ViewDocumentKeyDownEvent>( viewDocument, 'keydown', ( evt, data ) => { | ||
| if ( viewDocument.isComposing || | ||
| data.keystroke != keyCodes.backspace && !data.metaKey || |
There was a problem hiding this comment.
This condition solves the problem mentioned in the issue but introduces a new one. It's too broad. But I'm not sure how to make it more strict. Each time I tried, something else broke. Hmm...
pszczesniak
requested changes
Jan 27, 2025
I fixed the solution with the help of Kuba, and I am working on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Nested editable on Safari. Closes #17383.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.