Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal (image): Add loading=lazy to images with sources attribute. #17866

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Internal (image): Add loading=lazy to images with sources attribute. #17866

merged 1 commit into from
Feb 3, 2025

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Internal (image): Add loading=lazy to images with sources attribute. Closes #17865.

Additional information

⚠️ This PR targets the release branch ⚠️

mmotyczynska
mmotyczynska approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change does not affect the case for aspect-ratio, so there is a 🟢 from me.

pszczesniak
pszczesniak approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@pszczesniak pszczesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected 👍

@filipsobol filipsobol merged commit 1771a34 into release Feb 3, 2025
10 checks passed
@filipsobol filipsobol deleted the improve-handling-of-loading-lazy branch February 3, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pszczesniak pszczesniak pszczesniak approved these changes

@mmotyczynska mmotyczynska mmotyczynska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipsobol @pszczesniak @mmotyczynska