Fix the ordering of imports #143
Conversation
Pull Request Test Coverage Report for Build 467
💛 - Coveralls |
major
force-pushed
the
fix-import-ordering
branch
from
7807d86 to
186d474
Compare
There was a problem hiding this comment.
I'm conflicted on the results of this pull request. Some of it is fine, but some of it makes the orientation around imports more confusing and also introduces new pylint error.
flake8-import-order uses by default a very.. weird, for lack of better expression, ordering. I'd say if we are to use it, import style (and possibly application local imports) need to be properly configured first. We already established PEP8 and Google style guide complience, the tool supports checking both of these style guides. We should pick one of them and use it for the checks instead of the default which seems to go against those rules, what do you think?
| import time | ||
| from email.errors import HeaderParseError |
There was a problem hiding this comment.
Moving this introduces pylint error C: 26, 0: Imports from package email are not grouped (ungrouped-imports).
| import StringIO | ||
| from email.mime.application import MIMEApplication | ||
| from email.mime.multipart import MIMEMultipart | ||
| from email.mime.text import MIMEText |
There was a problem hiding this comment.
PEP8 doesn't say anything about the actual order in the groupings, but lexical order is usually used because of readability and orientation reasons. This breaks the lexical order while actually not fixing anything and making the orientation around imports more confusing?
|
Let's just forget about this one for now. |
This PR works towards the goals of #3 by ordering imports properly and checking those imports with
flake8-import-order.