Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Use consistent file handle naming #146

Merged
merged 1 commit into from
May 22, 2018

Conversation

major
Copy link
Contributor

@major major commented May 21, 2018

Fix variable names that violate pylint C0103 and use the same
name for all file handles.

Works towards #3.

Signed-off-by: Major Hayden [email protected]

@major major added the enhancement New feature or request label May 21, 2018
@major major self-assigned this May 21, 2018
@coveralls
Copy link

coveralls commented May 21, 2018

Pull Request Test Coverage Report for Build 494

  • 4 of 20 (20.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
skt/init.py 0 4 0.0%
skt/executable.py 0 6 0.0%
skt/reporter.py 0 6 0.0%
Totals Coverage Status
Change from base Build 493: 0.0%
Covered Lines: 684
Relevant Lines: 1466

💛 - Coveralls

spbnick
spbnick previously approved these changes May 22, 2018
Copy link
Contributor

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you, Major! However, this one seems to genuinely need a rebase.

Fix variable names that violate pylint C0103 and use the same
name for all file handles.

Signed-off-by: Major Hayden <[email protected]>
@major major force-pushed the consistent-filehandle-naming branch from 24a33e6 to b55ec91 Compare May 22, 2018 15:13
@major
Copy link
Contributor Author

major commented May 22, 2018

@spbnick Done!

@spbnick spbnick merged commit 193330a into cki-project:master May 22, 2018
@spbnick
Copy link
Contributor

spbnick commented May 22, 2018

Thank you, merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants