Simplify response code check

[major]

The response object has an ok method that returns True if the status
code is < 400.

This works towards #3.

Signed-off-by: Major Hayden [email protected]

[coveralls]

Pull Request Test Coverage Report for Build 471

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 46.658%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
skt/init.py	0	1	0.0%

Totals
Change from base Build 463:	0.0%
Covered Lines:	684
Relevant Lines:	1466

---

💛 - Coveralls

[veruu]

While technically this should be ok (no pun intended), we are retrieving directly the mbox and no redirects should occur. If they do, there's a chance something is wrong, and this would hide it.

[major]

@veruu True, but the requests module automatically follows redirects, so this should be okay as long as the resulting redirect returns something < 400.

http://docs.python-requests.org/en/master/api/

[veruu]

@veruu True, but the requests module automatically follows redirects,

That's exactly my point. How can we just roll with the redirects when we don't know where they end up, as they shouldn't be there in the first place? We'd end up with something that's not mbox and get unrelated errors later. I was thinking about using raise_for_status which basically does the same thing you propose (just more simple since we don't need to throw the exception ourselves but opted not to for exactly this reason.

[major]

I see your point. We can forget about this for now.