Remove deep merge in update #57
Conversation
|
Builds are failing here. I'd also appreciate it if you could add tests to cover functionality impacted by this change to assert that behaviour is identical before and after. |
|
Hey @rohan-deshpande. Absolutely. I fixed the build, seemed to be failing because of linting, which makes total sense. I just whipped up that change quickly. :) In terms of tests, I'm not exactly sure what test coverage to add, since from my reading of the code, the change I made should affect all update code and should be covered in all existing update paths. If you have an idea of a test pathway to add, I'm happy to do that. Does the overall idea of my change make sense? Is there something I'm missing in my understand that required the cloneDeep? |
|
@rohan-deshpande Any thoughts on merging this? |
claus
force-pushed
the
master
branch
6 times, most recently
from
954281b to
a5b8e65
Compare
No description provided.