Option to restrict simple list item creation #1548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjpaulino
reviewed
Nov 11, 2022
inputs/simple-list-input.vue
Outdated
| // Only saves values from the autocomplete list if tag creation restriction is enabled | ||
| if (this.restrictItemCreation) { | ||
| if (!this.autocompleteValue) { | ||
| this.autocompleteValue = false; |
There was a problem hiding this comment.
If autocompleteValue is false and meets the criteria, why do you assign false again to it? 👀
inputs/simple-list.vue
Outdated
| @@ -404,5 +418,12 @@ | |||
| .list-items-leave-active { | |||
| transition: opacity $standard-time $standard-curve; | |||
| } | |||
|
|
|||
| .restriction-error-message { | |||
| color: rgba(255, 0, 0, 0.54); | |||
There was a problem hiding this comment.
Could you use the corresponding hex value of this color?
inputs/simple-list.vue
Outdated
| @@ -359,6 +365,14 @@ | |||
| }); | |||
| this.update(this.items); | |||
| } | |||
| }, | |||
| onTriggerRestrictionError() { | |||
| if (this.args.restrictedErrrorMessage) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.args.restrictedErrrorMessage) { | |
| if (this.args.restrictedErrorMessage) { |
inputs/simple-list.vue
Outdated
| <div class="ui-textbox__feedback" v-if="hasFeedback || maxLength"> | ||
| <div class="ui-textbox__feedback-text" v-if="showError">{{ error }}</div> | ||
| <div class="ui-textbox__feedback-text" v-else-if="showHelp">{{ args.help }}</div> | ||
| <div class="ui-textbox__counter" v-if="maxLength"> | ||
| {{ valueLength + '/' + maxLength }} | ||
| </div> | ||
| </div> | ||
| <div class="restriction-error-message" v-if="showRestrictionError">{{ args.restrictedErrrorMessage }}</div> |
There was a problem hiding this comment.
Suggested change
| <div class="restriction-error-message" v-if="showRestrictionError">{{ args.restrictedErrrorMessage }}</div> | |
| <div class="restriction-error-message" v-if="showRestrictionError">{{ args.restrictedErrorMessage }}</div> |
Also, should you add this property to the docs too?
james-owen
approved these changes
Nov 29, 2022
Jess2896
force-pushed
the
sites-admin-tags
branch
from
09ab847 to
3071ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Info
Jira Ticket Url
Description