Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added faq page #235

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Added faq page #235

merged 7 commits into from
Nov 15, 2023

Conversation

sanjanag
Copy link
Member

@sanjanag sanjanag commented Nov 13, 2023

  • Added FAQ page
  • Fixed linking for fsspec_dataset class
  • Reworded some of the text in Quickstart page.

Preview link: https://cleanvision--235.org.readthedocs.build/en/235/index.html

@sanjanag sanjanag requested a review from jwmueller November 13, 2023 18:06
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2814ed8) 95.74% compared to head (e2ca4c5) 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   95.74%   95.84%   +0.10%     
==========================================
  Files          16       16              
  Lines         986      986              
  Branches      158      194      +36     
==========================================
+ Hits          944      945       +1     
+ Misses         22       21       -1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had many questions

- Added faq page
- fixed broken links
- Changed wording for some sections
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/source/faq.rst Outdated Show resolved Hide resolved
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one suggestion but go ahead and merge after considering that change

@sanjanag sanjanag merged commit 1c6fa9d into cleanlab:main Nov 15, 2023
22 of 24 checks passed
@sanjanag sanjanag deleted the faq branch November 15, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants