Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-cleanup step in the actions workflow #3

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

JohnnyLiu2886
Copy link
Collaborator

remove the process for removing the debian packages in the workflow file

@JohnnyLiu2886 JohnnyLiu2886 changed the title Release: v2.1.0 Release: v2.1.1 Nov 10, 2023
Copy link
Member

@utkarsh867 utkarsh867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in github workflow does not warrant a change in the version of the apt package itself.

If you would like to think of it another way:
v2.1.0 and v2.1.1 would have no difference because github workflow is not present in the package itself. so apt would do nothing, even though it would change the version.

@utkarsh867 utkarsh867 changed the title Release: v2.1.1 Remove pre-cleanup step in the actions workflow Nov 10, 2023
@utkarsh867
Copy link
Member

The self-hosted runner now has the post-cleanup after each action.

@utkarsh867
Copy link
Member

@JohnnyLiu2886 the e4c1a66 commit needs to be removed.

@JohnnyLiu2886
Copy link
Collaborator Author

@JohnnyLiu2886 the e4c1a66 commit needs to be removed.

ok, it is removed

@utkarsh867 utkarsh867 merged commit 7c061ad into foxy Nov 15, 2023
2 checks passed
@utkarsh867 utkarsh867 deleted the modifiy_workflow branch November 15, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants