-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Registry to abstract serializing and deserialzing xml into kml objects (Sourcery refactored) #297
Conversation
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 61% smaller than the GitHub diff.
|
PR Summary
|
PR Description updated to latest commit (eaf351f) |
PR Analysis(review updated until commit eaf351f)
PR Feedback💡 General suggestions: The changes made in this PR are concise and improve the readability of the code. However, it would be beneficial to include tests that ensure the refactored methods behave as expected. 🤖 Code feedback:
✨ Usage tips:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## registry #297 +/- ##
============================================
- Coverage 95.52% 95.52% -0.01%
============================================
Files 42 42
Lines 3865 3864 -1
Branches 214 214
============================================
- Hits 3692 3691 -1
Misses 135 135
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Persistent review updated to latest commit eaf351f |
eaf351f
to
db85bee
Compare
element = super().etree_element(precision=precision, verbosity=verbosity) | ||
return element | ||
return super().etree_element(precision=precision, verbosity=verbosity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function _Geometry.etree_element
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
Pull Request #296 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
registry
branch, then run:Help us improve this pull request!