Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add csharp and python svgs; move all svgs into partials #1989

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Feb 5, 2025

🔎 Previews:

What changed?

  • Adds missing Python and C# cards to /index and /references/overview
  • Moves all svg's into partials to be reused across /index, /references/overview, and /quickstarts/overview

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@alexisintech alexisintech requested a review from a team as a code owner February 5, 2025 17:51
Copy link

github-actions bot commented Feb 5, 2025

Hey, here’s your docs preview: https://clerk.com/docs/pr/1989

Copy link

github-actions bot commented Feb 5, 2025

⚠️ Changes found in the following quickstarts:

  • overview.mdx

⚠️ Please update the corresponding quickstarts in the Dashboard

Copy link

github-actions bot commented Feb 5, 2025

⚠️ Changes found in the following quickstarts:

  • overview.mdx

⚠️ Please update the corresponding quickstarts in the Dashboard

@alexisintech alexisintech merged commit c72428a into main Feb 5, 2025
6 checks passed
@alexisintech alexisintech deleted the aa/add-missing-references branch February 5, 2025 18:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old version of the C# logo. Here's my recommendation:

<svg viewBox="0 0 160 178" fill="none">
  <path
    fill="url(#c-sharp-logo-gradient)"
    d="M0 55.847v65.985a22.844 22.844 0 0 0 11.429 19.791l57.143 32.997a22.848 22.848 0 0 0 22.857 0l57.143-32.997A22.854 22.854 0 0 0 160 121.831V55.847a22.848 22.848 0 0 0-11.428-19.794L91.429 3.065a22.842 22.842 0 0 0-22.857 0L11.429 36.053A22.856 22.856 0 0 0 0 55.847Z"
  />

  <path
    fill="#fff"
    d="M40.552 78.02v22.774a5.68 5.68 0 0 0 3.514 5.263 5.684 5.684 0 0 0 2.18.431 5.7 5.7 0 0 0 4.028-1.667 5.694 5.694 0 0 0 1.667-4.027 5.693 5.693 0 1 1 11.385 0 17.08 17.08 0 0 1-34.159 0v-22.77a17.08 17.08 0 1 1 34.159 0 5.693 5.693 0 0 1-11.385 0 5.693 5.693 0 0 0-11.386 0l-.003-.004Zm91.088 22.774a5.68 5.68 0 0 1-3.514 5.262 5.681 5.681 0 0 1-2.18.432h-5.694v5.691a5.68 5.68 0 0 1-1.668 4.026 5.683 5.683 0 0 1-6.204 1.238 5.707 5.707 0 0 1-3.513-5.264v-5.691H97.481v5.691a5.682 5.682 0 0 1-5.694 5.694 5.682 5.682 0 0 1-5.69-5.694v-5.691h-5.698a5.695 5.695 0 0 1-5.693-5.693 5.693 5.693 0 0 1 5.693-5.692h5.694V83.718h-5.694a5.693 5.693 0 0 1 0-11.386h5.694v-5.694a5.693 5.693 0 1 1 11.385 0v5.691h11.385v-5.69a5.691 5.691 0 0 1 9.718-4.026 5.691 5.691 0 0 1 1.668 4.025v5.691h5.694c1.508 0 2.957.598 4.023 1.668a5.68 5.68 0 0 1 0 8.05 5.692 5.692 0 0 1-4.023 1.67h-5.694v11.386h5.694a5.71 5.71 0 0 1 5.697 5.691Zm-22.773-17.076H97.481v11.385h11.386V83.718Z"
  />

  <defs>
    <linearGradient
      id="c-sharp-logo-gradient"
      x1="15.713"
      x2="92.858"
      y1="38.841"
      y2="173.129"
      gradientUnits="userSpaceOnUse"
    >
      <stop stopColor="#927BE5" />

      <stop offset="1" stopColor="#512BD4" />
    </linearGradient>
  </defs>
</svg>

<img
width="32"
height="32"
alt="tanstack start logo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant and noisy because the logos are displayed with names/titles already. Can we replace with alt=""?

</Cards>

## Explore by feature

<Cards variant="plain">
<Cards>
- [What is the "User" object?](/docs/users/overview)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line shouldn't be here? 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh what the hell LOL

</Cards>

## Explore by feature

<Cards variant="plain">
<Cards>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for changing the layout of this section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually didn't mean to - good catch 😟

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's messing with the colours in this logo. Here's my recommendation:

Before After
CleanShot 2025-02-05 at 18 35 24@2x CleanShot 2025-02-05 at 18 35 17@2x
<svg viewBox="0 0 112 114" height="114" fill="none">
  <path
    fill="url(#python-logo-gradient-1)"
    d="M55.333 0c-4.618.022-9.029.416-12.91 1.103-11.43 2.02-13.507 6.247-13.507 14.043V25.44h27.015v3.432H18.778c-7.851 0-14.726 4.72-16.876 13.697-2.48 10.29-2.59 16.71 0 27.455 1.92 7.998 6.506 13.696 14.357 13.696h9.288V71.38c0-8.917 7.715-16.782 16.877-16.782h26.983c7.511 0 13.508-6.184 13.508-13.728V15.146c0-7.322-6.177-12.821-13.508-14.043C64.767.33 59.951-.021 55.333 0Zm-14.61 8.282c2.791 0 5.07 2.316 5.07 5.163 0 2.838-2.279 5.133-5.07 5.133-2.8 0-5.069-2.295-5.069-5.133 0-2.847 2.27-5.163 5.07-5.163Z"
  />

  <path
    fill="url(#python-logo-gradient-2)"
    d="M86.284 28.873V40.87c0 9.3-7.885 17.128-16.876 17.128H42.424c-7.39 0-13.507 6.326-13.507 13.728v25.723c0 7.322 6.366 11.628 13.507 13.728 8.552 2.515 16.752 2.969 26.984 0 6.8-1.969 13.507-5.932 13.507-13.728V87.154H55.932v-3.432h40.49c7.852 0 10.777-5.477 13.508-13.697 2.82-8.462 2.7-16.6 0-27.455-1.941-7.816-5.646-13.697-13.508-13.697H86.284ZM71.108 94.018c2.8 0 5.07 2.294 5.07 5.132 0 2.847-2.27 5.163-5.07 5.163-2.79 0-5.07-2.316-5.07-5.163 0-2.838 2.28-5.133 5.07-5.133Z"
  />

  <defs>
    <linearGradient
      id="python-logo-gradient-1"
      x1="0"
      x2="62.293"
      y1="0"
      y2="53.082"
      gradientUnits="userSpaceOnUse"
    >
      <stop stopColor="#5A9FD4" />

      <stop offset="1" stopColor="#306998" />
    </linearGradient>

    <linearGradient
      id="python-logo-gradient-2"
      x1="70.459"
      x2="48.11"
      y1="98.284"
      y2="66.967"
      gradientUnits="userSpaceOnUse"
    >
      <stop stopColor="#FFD43B" />

      <stop offset="1" stopColor="#FFE873" />
    </linearGradient>
  </defs>
</svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants