Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor(clerk-js,types): Remove virtual routing option from component types" #5057

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Revert "refactor(clerk-js,types): Remove virtual routing option from component types" #5057

merged 5 commits into from
Jan 31, 2025

Conversation

alexcarpenter
Copy link
Member

Reverts #4977

@linear Linear
Copy link

linear bot commented Jan 31, 2025

Issue reopened: SDKI-803 Drop routing "virtual" from types

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ec8bec1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 8:41pm

@alexcarpenter alexcarpenter requested a review from brkalow January 31, 2025 18:50
brkalow
brkalow reviewed Jan 31, 2025
View reviewed changes
packages/types/src/clerk.ts Outdated Show resolved Hide resolved
packages/types/src/clerk.ts Outdated Show resolved Hide resolved
@brkalow brkalow merged commit f976349 into main Jan 31, 2025
29 checks passed
@brkalow brkalow deleted the revert-4977-alexcarpenter/sdki-803-drop-routing-virtual-from-types branch January 31, 2025 20:51
@clerk-cookie clerk-cookie mentioned this pull request Jan 31, 2025
Merged
@alexcarpenter alexcarpenter mentioned this pull request Jan 31, 2025
Closed
4 tasks
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
@alexcarpenter @brkalow @wobsoriano
Revert "refactor(clerk-js,types): Remove virtual routing option from …
81c9984 
…component types" (#5057)

Co-authored-by: Bryce Kalow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brkalow brkalow brkalow approved these changes

Assignees
No one assigned
Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcarpenter @brkalow @clerk-cookie