feat(clerk-js,types): Navigate to session tasks #5187

LauraBeatris · 2025-02-17T21:15:51Z

Description

Resolves ORGS-562

Displays the current pending session task as a SignIn/SignUp routes
Introduce client-side navigation once session updates to pending with tasks

After sign-in

CleanShot.2025-02-19.at.15.43.57.mp4

After sign-up

CleanShot.2025-02-19.at.15.45.42.mp4

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2025-02-17T21:15:56Z

🦋 Changeset detected

Latest commit: e15d124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/types	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/agent-toolkit	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/react-router	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch
@clerk/ui	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-02-17T21:15:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 25, 2025 4:29pm

LauraBeatris · 2025-02-19T01:30:55Z

packages/types/src/session.ts

@@ -197,7 +198,7 @@ export interface PublicUserData {
 }

 export interface SessionTask {
-  key: 'orgs';


FAPI was previously returning orgs but it got updated to org

LauraBeatris · 2025-02-25T16:31:22Z

integration/tests/session-tasks.test.ts

+import { testAgainstRunningApps } from '../testUtils';
+
+// TODO ORGS-566 - write integration tests for after-auth flow
+testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('after-auth flows @generic @nextjs', () => {


This is just a placeholder for me to come back later which is helpful to visualize the redirection behavior introduced in this PR

The reason integration tests aren't being implemented is that FAPI changes for that are under development and it could break CI

LauraBeatris added the blocked label Feb 17, 2025

LauraBeatris self-assigned this Feb 17, 2025

clerk-cookie added the clerk-js label Feb 17, 2025

LauraBeatris changed the title ~~[wip] feat(clerk-js): Display pending tasks on SignIn/SignUp~~ [wip] chore(clerk-js): Display pending tasks on SignIn/SignUp Feb 17, 2025

LauraBeatris force-pushed the introduce-session-tasks-types branch from e2e02ec to aa2c20a Compare February 18, 2025 16:26

Base automatically changed from introduce-session-tasks-types to main February 18, 2025 16:35

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 59a2b22 to e836ee1 Compare February 18, 2025 16:39

vercel bot had a problem deploying to Preview February 18, 2025 16:41 Failure

vercel bot had a problem deploying to Preview February 18, 2025 19:58 Failure

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 62a62ae to 639e7f8 Compare February 18, 2025 21:13

vercel bot had a problem deploying to Preview February 18, 2025 21:14 Failure

clerk-cookie added the types label Feb 18, 2025

vercel bot deployed to Preview February 18, 2025 22:42 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 755c683 to 4a6e892 Compare February 18, 2025 22:45

vercel bot deployed to Preview February 18, 2025 22:46 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 4a6e892 to a1c1c39 Compare February 18, 2025 23:26

vercel bot deployed to Preview February 18, 2025 23:28 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch 2 times, most recently from d27d8c9 to 104791b Compare February 18, 2025 23:31

vercel bot deployed to Preview February 18, 2025 23:32 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 104791b to 48191f1 Compare February 19, 2025 01:21

vercel bot deployed to Preview February 19, 2025 01:22 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 48191f1 to d74f3e7 Compare February 19, 2025 01:28

vercel bot deployed to Preview February 19, 2025 01:29 View deployment

LauraBeatris commented Feb 19, 2025

View reviewed changes

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from d74f3e7 to 08a8aff Compare February 19, 2025 01:32

vercel bot deployed to Preview February 19, 2025 01:33 View deployment

LauraBeatris removed the blocked label Feb 19, 2025

LauraBeatris added 7 commits February 24, 2025 10:37

Fix session task key

f44a7ec

Implement unit tests for Task component

43beb76

Add unit tests for useTaskRoute

46fe2b8

Add option for a custom tasks URL to cover custom flow

9234c79

Refactor redirect guards for tasks

d38dbbc

Does not trigger redirectUrl logic

1dc30d5

Trigger navigation on client-piggybacking

36e0c91

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 3e274ee to 36e0c91 Compare February 24, 2025 15:40

vercel bot deployed to Preview February 24, 2025 15:41 View deployment

Set tasks URL on the sign-in/sign-up context

f1e64f1

vercel bot deployed to Preview February 24, 2025 15:58 View deployment

Introduce separate redirect guards for tasks

9a5415d

vercel bot deployed to Preview February 24, 2025 16:59 View deployment

vercel bot deployed to Preview February 24, 2025 17:59 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from d2fe62a to edc02d0 Compare February 24, 2025 18:01

vercel bot deployed to Preview February 24, 2025 18:02 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from edc02d0 to 2855447 Compare February 24, 2025 20:44

vercel bot deployed to Preview February 24, 2025 20:45 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 2855447 to 2f7c8a3 Compare February 24, 2025 22:10

vercel bot deployed to Preview February 24, 2025 22:11 View deployment

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 2f7c8a3 to 5c5bc89 Compare February 24, 2025 22:13

vercel bot deployed to Preview February 24, 2025 22:14 View deployment

Add unit test for redirection to task

1233d3b

LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 5c5bc89 to 1233d3b Compare February 24, 2025 22:31

vercel bot deployed to Preview February 24, 2025 22:32 View deployment

LauraBeatris changed the title ~~feat(clerk-js,types): Navigate to after-auth tasks~~ feat(clerk-js,types): Navigate to session tasks Feb 25, 2025

Introduce skeleton for integration tests

e15d124

clerk-cookie added the integration label Feb 25, 2025

vercel bot deployed to Preview February 25, 2025 16:29 View deployment

LauraBeatris commented Feb 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(clerk-js,types): Navigate to session tasks #5187

feat(clerk-js,types): Navigate to session tasks #5187

LauraBeatris commented Feb 17, 2025 •

edited

Loading

changeset-bot bot commented Feb 17, 2025 •

edited

Loading

vercel bot commented Feb 17, 2025 •

edited

Loading

LauraBeatris Feb 19, 2025

LauraBeatris Feb 25, 2025

feat(clerk-js,types): Navigate to session tasks #5187

Are you sure you want to change the base?

feat(clerk-js,types): Navigate to session tasks #5187

Conversation

LauraBeatris commented Feb 17, 2025 • edited Loading

Description

After sign-in

After sign-up

Checklist

Type of change

changeset-bot bot commented Feb 17, 2025 • edited Loading

🦋 Changeset detected

vercel bot commented Feb 17, 2025 • edited Loading

LauraBeatris Feb 19, 2025

Choose a reason for hiding this comment

LauraBeatris Feb 25, 2025

Choose a reason for hiding this comment

LauraBeatris commented Feb 17, 2025 •

edited

Loading

changeset-bot bot commented Feb 17, 2025 •

edited

Loading

vercel bot commented Feb 17, 2025 •

edited

Loading