Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java.util.Base64 instead of BASE64Encoder #41

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

danielcompton
Copy link
Member

For backwards/forwards compatibility between implementations, adds a
trailing newline to the string to match the behaviour of the sun.misc.BASE64Decoder.

This effectively sets the minimum JVM to Java 8, at least to use this
namespace.

For backwards/forwards compatibility between implementations, adds a
trailing newline to the string to match the behaviour of the sun.misc.BASE64Decoder.

This effectively sets the minimum JVM to Java 8, at least to use this
namespace.
@puredanger
Copy link

Based on data from the 2018 State of Clojure (almost a year ago), 93% of the community was using Java 8 or higher. I expect that number is higher now.

@danielcompton
Copy link
Member Author

Thanks @puredanger that's very helpful information. I had thought about asking a question on the mailing list but had forgotten about the survey data. I'm leaning towards merging this then, but will give it a little bit more time for others to comment also.

@NoahTheDuke
Copy link

If this is going to be merged, can the existing reliance on the sun.misc.* stuff be removed? While it's still in, the library is unusable from java 11+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants