Update Base64 to modern Java #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| (defn unsmash [^String str] |
There was a problem hiding this comment.
Can you add the type hint back in? There will be reflection without it.
| @@ -1,20 +1,22 @@ | |||
| (defproject org.flatland/useful "0.11.7-SNAPSHOT" | |||
| :description "A collection of generally-useful Clojure utility functions" | |||
| :license {:name "Eclipse Public License - v 1.0" | |||
| :url "http://www.eclipse.org/legal/epl-v10.html" | |||
| :license {:name "Eclipse Public License - v 1.0" | |||
There was a problem hiding this comment.
Would it be possible to only make the changes to the dependencies here without the reformatting?
| :plugins [[codox "0.8.0"]] | ||
| :codox {:src-dir-uri "http://github.com/flatland/useful/blob/develop/" | ||
| :plugins [[codox "0.8.0"] | ||
| [lein-ancient "0.6.15"]] |
There was a problem hiding this comment.
I don't know if we need this in the plugins here?
| :dependencies [[org.clojure/clojure "1.8.0" :scope "provided"] | ||
| [org.clojure/tools.macro "0.1.5"] | ||
| [org.clojure/tools.reader "1.3.2"]] | ||
| :aliases {"testall" ["with-profile" ":1.8:1.9:1.10" "test"]} |
There was a problem hiding this comment.
Suggested change
| :aliases {"testall" ["with-profile" ":1.8:1.9:1.10" "test"]} | |
| :aliases {"testall" ["with-profile" "1.8:1.9:1.10" "test"]} |
The : here is a delimiter, not part of the profile name itself so we don't need a leading one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with Clojure 1.8/1.10.1 and Java 8/12