Autoadd # noqa with ruff check . --add-noqa

bin/__init__.py

@@ -0,0 +1 @@
+# noqa: EXE002

bin/backfix-duplicate-categories.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 # Duplicate categories were created because of an inadequate unique constraint
 # in MySQL. This script deletes duplicate categories with no messages
 # associated. If two or more duplicate categories exist with associated

bin/backfix-generic-imap-separators.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 # We previously didn't store IMAP path separators for generic imap accounts.
 # This script backfixes the accounts.
 

bin/check-attachments.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 # Check that we can fetch attachments for 99.9% of our syncing accounts.
 import concurrent.futures
 import datetime
@@ -20,7 +20,7 @@
 NUM_MESSAGES = 10
 
 
-def process_account(account_id):
+def process_account(account_id):  # noqa: ANN201
     ret = defaultdict(int)
 
     try:

bin/clear-all-heartbeats.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 from sys import exit

bin/clear-db.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 import argparse
 import sys
 

bin/clear-heartbeat-status.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 from sys import exit

bin/clear-kv.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 from sys import exit
 

bin/correct-autoincrements.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import click

bin/create-db.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import os
@@ -81,7 +81,7 @@ def main(target_hostname, host_ip) -> None:
                 alembic_ini_filename = os.environ.get(
                     "ALEMBIC_INI_PATH", "alembic.ini"
                 )
-                assert os.path.isfile(
+                assert os.path.isfile(  # noqa: PTH113
                     alembic_ini_filename
                 ), f"Must have alembic.ini file at {alembic_ini_filename}"
                 alembic_cfg = alembic.config.Config(alembic_ini_filename)

bin/create-encryption-keys.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import binascii
@@ -36,11 +36,11 @@ def main() -> None:
     # so it better exist.
     # Update it
     try:
-        with open(secrets_path, "a") as f:
+        with open(secrets_path, "a") as f:  # noqa: PTH123
             print(f"Writing keys to secrets config file {secrets_path}")
             yaml.dump(data, f, default_flow_style=False)
     except OSError:
-        raise Exception(
+        raise Exception(  # noqa: B904
             f"Check file write permissions on config file {secrets_path}"
         )
 

bin/create-event-contact-associations.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 """
 Create event contact associations for events that don't have any.
 """

bin/delete-account-data.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 """
 Deletes an account's data permanently.
 
@@ -63,7 +63,7 @@ def delete_account_data(account_id, dry_run, yes, throttle) -> int | None:
             )
         )
 
-        answer = raw_input(question).strip().lower()
+        answer = raw_input(question).strip().lower()  # noqa: F821
 
         if answer != "yes":
             print("Will NOT delete, goodbye.")

bin/delete-marked-accounts.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 """
 Searches for accounts that are marked for deletion and deletes
 all of their data

bin/detect-missing-sync-host.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import click
@@ -17,7 +17,7 @@ def main() -> None:
     was _started_ on a new host without being first stopped on its previous
     host.)
 
-    """
+    """  # noqa: D401
     maybe_enable_rollbar()
 
     with global_session_scope() as db_session:

bin/get-accounts-for-host.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: EXE001, N999
 
 
 import click

bin/get-id.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 # Query the id corresponding to a public id and vice-versa.
 
 
@@ -40,7 +40,7 @@
 def main(type, id, public_id) -> None:
     maybe_enable_rollbar()
 
-    type = type.lower()
+    type = type.lower()  # noqa: A001
 
     if type not in cls_for_type:
         print(f"Error: unknown type '{type}'")

bin/get-object.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 # Query the id corresponding to a public id and vice-versa.
 
 
@@ -51,7 +51,7 @@
 def main(type, id, public_id, account_id, namespace_id, readwrite) -> None:
     maybe_enable_rollbar()
 
-    type = type.lower()
+    type = type.lower()  # noqa: A001
 
     if type not in cls_for_type:
         print(f"Error: unknown type '{type}'")

bin/inbox-api.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 import os
 import sys
@@ -49,7 +49,7 @@ def main(prod, config, port) -> None:
     maybe_enable_rollbar()
 
     if config is not None:
-        config_path = os.path.abspath(config)
+        config_path = os.path.abspath(config)  # noqa: PTH100
         load_overrides(config_path)
 
     start(port=int(port), use_reloader=not prod)

bin/inbox-auth.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import sys

bin/inbox-console.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 from setproctitle import setproctitle

bin/inbox-start.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import os
@@ -83,13 +83,15 @@ def main(prod, enable_profiler, config, process_num) -> None:
     if config is not None:
         from inbox.util.startup import load_overrides
 
-        config_path = os.path.abspath(config)
+        config_path = os.path.abspath(config)  # noqa: PTH100
         load_overrides(config_path)
 
     if not prod:
         preflight()
 
-    total_processes = int(os.environ.get("MAILSYNC_PROCESSES", 1))
+    total_processes = int(
+        os.environ.get("MAILSYNC_PROCESSES", 1)  # noqa: PLW1508
+    )
 
     setproctitle.setproctitle(f"sync-engine-{process_num}")
 

bin/migrate-db.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import os
@@ -15,7 +15,7 @@ def main() -> None:
     maybe_enable_rollbar()
 
     alembic_ini_filename = os.environ.get("ALEMBIC_INI_PATH", "alembic.ini")
-    assert os.path.isfile(
+    assert os.path.isfile(  # noqa: PTH113
         alembic_ini_filename
     ), f"Missing alembic.ini file at {alembic_ini_filename}"
 

bin/mysql-prompt.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import subprocess
@@ -51,7 +51,7 @@ def main(shard_num: int | None, execute: str | None, batch: bool) -> None:
                 creds["db_name"] = shard["SCHEMA_NAME"]
                 break
 
-    for key in creds.keys():
+    for key in creds.keys():  # noqa: PLC0206
         if creds[key] is None:
             print(f"Error: {key} is None")
             sys.exit(-1)

bin/purge-transaction-log.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 """
 Deletes entries in the transaction older than `days_ago` days( as measured by
 the created_at column)

bin/remove-message-attachments.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 import datetime
 import enum
 import logging

bin/restart-forgotten-accounts.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: EXE001, N999
 
 import time
 

bin/set-desired-host.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: EXE001, N999
 
 
 import click

bin/set-throttled.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: EXE001, N999
 # throttle or unthrottle an account
 
 
@@ -49,7 +49,7 @@ def main() -> None:
     parser.add_option("--unthrottled", action="store_true", default=False)
     parser.add_option("--id", action="store", dest="account_id", default=None)
     parser.add_option("--stdin", action="store_true", default=False)
-    options, remainder = parser.parse_args(sys.argv[1:])
+    options, remainder = parser.parse_args(sys.argv[1:])  # noqa: F841
     if all(opt is False for opt in [options.throttled, options.unthrottled]):
         print_usage()
         sys.exit(-1)
@@ -67,7 +67,7 @@ def main() -> None:
             if len(splat) < 2:
                 continue
 
-            email, id = splat[:2]
+            email, id = splat[:2]  # noqa: A001, F841
             options.account_id = id
             throttle(options)
 

bin/stamp-db.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import os
@@ -16,7 +16,7 @@ def main(revision_id) -> None:
     maybe_enable_rollbar()
 
     alembic_ini_filename = os.environ.get("ALEMBIC_INI_PATH", "alembic.ini")
-    assert os.path.isfile(
+    assert os.path.isfile(  # noqa: PTH113
         alembic_ini_filename
     ), f"Missing alembic.ini file at {alembic_ini_filename}"
 

bin/sync-single-account.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 import logging
 from threading import BoundedSemaphore

bin/syncback-service.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 """
 Run the syncback service separately. You should run this if you run the
 API under something like gunicorn. (For convenience, the bin/inbox-api script
@@ -58,13 +58,15 @@ def main(prod, config, process_num, syncback_id, enable_profiler) -> None:
     print("Python", sys.version, file=sys.stderr)
 
     if config is not None:
-        config_path = os.path.abspath(config)
+        config_path = os.path.abspath(config)  # noqa: PTH100
         load_overrides(config_path)
     level = os.environ.get("LOGLEVEL", inbox_config.get("LOGLEVEL"))
     configure_logging(log_level=level)
     reconfigure_logging()
 
-    total_processes = int(os.environ.get("SYNCBACK_PROCESSES", 1))
+    total_processes = int(
+        os.environ.get("SYNCBACK_PROCESSES", 1)  # noqa: PLW1508
+    )
 
     def start():
         # Start the syncback service, and just hang out forever

bin/syncback-stats.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 import click
 from sqlalchemy import func

bin/unschedule-account-syncs.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import click
@@ -27,7 +27,7 @@ def main(dry_run, number, hostname, process) -> None:
             "You have not provided a --number option. This will "
             "unschedule ALL syncs on the host. Proceed? [Y/n] "
         )
-        if raw_input(message).strip().lower() == "n":
+        if raw_input(message).strip().lower() == "n":  # noqa: F821
             print("Will not proceed")
             return
 
@@ -38,7 +38,7 @@ def main(dry_run, number, hostname, process) -> None:
                 hostname
             )
         )
-        if raw_input(message).strip().lower() == "n":
+        if raw_input(message).strip().lower() == "n":  # noqa: F821
             print("Bailing out")
             return
 

bin/update-categories.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 import click

bin/verify-db.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python  # noqa: N999
 
 
 from inbox.config import config

inbox/actions/base.py

@@ -51,7 +51,7 @@
 log = get_logger()
 
 
-def can_handle_multiple_records(action_name):
+def can_handle_multiple_records(action_name):  # noqa: ANN201
     return action_name == "change_labels"