Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address remaining flake8-simplify lints that could not be done on Python 2 #314

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Address remaining flake8-simplify lints that could not be done on Python 2 #314

merged 4 commits into from
Feb 14, 2022

Conversation

squeaky-pl
Copy link
Contributor

@squeaky-pl squeaky-pl commented Feb 14, 2022 •
edited
Loading

Partly addresses: #311

@squeaky-pl squeaky-pl requested a review from jpmelos February 14, 2022 13:20
@jpmelos jpmelos mentioned this pull request Feb 14, 2022
Merged
jpmelos
jpmelos approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@jpmelos jpmelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except the small thing about comments addressed in #315. If you like that, feel free to merge that into this PR and merge. 😄

@squeaky-pl squeaky-pl merged commit e029bd2 into master Feb 14, 2022
@squeaky-pl squeaky-pl deleted the simplify-py3 branch February 14, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmelos jpmelos jpmelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squeaky-pl @jpmelos