Google: Pass eventTypes #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this manually in production on the pod where my email/calendar is running and all is good. |
wojcikstefan
approved these changes
Feb 8, 2024
inbox/events/google.py
Outdated
Comment on lines
135
to
137
| params = {"eventTypes": "default"} | ||
| try: | ||
| return self._get_resource_list(url, updatedMin=sync_from_time_str) | ||
| return self._get_resource_list(url, updatedMin=sync_from_time_str, **params) |
There was a problem hiding this comment.
Why the use of kwargs? Is it because the linter would complain about passing eventTypes="default" explicitly to the function call since it's not the typical Pythonic snake_case?
There was a problem hiding this comment.
That was indeed unnecessary, I changed it.
|
@squeaky-pl shall we ship it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google will soon start returning other event types in their APIs that we don't care about. This change ensures that everything keeps working as before.
https://developers.google.com/calendar/api/v3/reference/events/list