Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #987

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Remove dead code #987

merged 3 commits into from
Dec 16, 2024

Conversation

neob91-close
Copy link
Contributor

This removes code that is completely unreferenced and unused.

inbox/api/wsgi.py Outdated Show resolved Hide resolved
@neob91-close
Copy link
Contributor Author

Rebased to resolve conflicts after #988

Copy link
Contributor

@tsx tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very qualified to tell if this is really unused.

@neob91-close
Copy link
Contributor Author

An extra piece of context - I used the dead code linter from our main repository. Only objects whose identifiers that do not appear in all Python files more than once were removed.

Copy link
Contributor

@squeaky-pl squeaky-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@neob91-close neob91-close merged commit 1ed7d96 into master Dec 16, 2024
4 checks passed
@neob91-close neob91-close deleted the remove-dead-code branch December 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants