Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my Vite investigation, I realized that this package's ESM output wasn't working correctly.
Although we were renaming
index.js
toindex.mjs
on thebuild:esm
script, the imports weren't working for two reasons:.mjs
extension, otherwise the file is considered a CommonJS module..mjs
, it wasn't working, because the imports inside the files need to use the extension.In order to ease the process, I just added tsup which supports outputting both formats.
I already published the package as
v0.2.2
so I just need a review in order to merge this.