Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #158

Merged
merged 81 commits into from
Jan 13, 2025
Merged

Dev #158

Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
b2ee5b7
Merge pull request #118 from closup/open-new-tab
lucakato Oct 10, 2024
f172bb8
debug logs
lucakato Oct 17, 2024
187e402
parenth for negative values
lucakato Oct 17, 2024
b730391
another attempt, new func
lucakato Oct 17, 2024
878423c
reconc tables for pittsburg
lucakato Oct 17, 2024
2aa9dcd
Revert "reconc tables for pittsburg"
lucakato Oct 17, 2024
c0d742e
negative numbers should now have () around it
lucakato Oct 22, 2024
41fb741
now we can export it as a table (for sheets where xbrl element is set…
lucakato Oct 22, 2024
705f49c
set it to None
lucakato Oct 22, 2024
96f587a
sarrah's blank template with business activities set to N converted
lucakato Oct 29, 2024
8325e37
SF template worked with this
lucakato Oct 29, 2024
fec6f8e
robust checking for hidden cols
lucakato Oct 29, 2024
77fa3ba
Merge pull request #123 from closup/122-bs-actv-N
lucakato Oct 29, 2024
c106af0
Merge pull request #124 from closup/main
kwheelan Nov 11, 2024
4148adb
#122 uploading emailed template
kwheelan Nov 18, 2024
fb30691
Update .gitignore
lucakato Nov 18, 2024
f37d83d
Merge pull request #135 from closup/128-hide-env
lucakato Nov 18, 2024
4a57934
Update .env
lucakato Nov 18, 2024
2265599
Delete .env
lucakato Nov 18, 2024
03c84f7
Merge pull request #136 from closup/128-new-flask-key
lucakato Nov 18, 2024
1dac318
fix heading formatting issues
lucakato Nov 25, 2024
8adbf4b
Merge pull request #137 from closup/129-header-format-issues
lucakato Nov 25, 2024
6c62fd2
removed context
lucakato Nov 25, 2024
9a8441a
Merge pull request #138 from closup/131-revert-recon-clickable
lucakato Nov 25, 2024
8f8bb43
Fixing template
sarraha786 Nov 27, 2024
ff09162
opens new tab only after conversion / viewer is created
lucakato Dec 3, 2024
23bad2b
center the 'combine and convert' button
lucakato Dec 3, 2024
6938563
Merge pull request #142 from closup/134-tab-open
lucakato Dec 3, 2024
08a73b5
Merge pull request #127 from closup/122-template-conditions
kwheelan Dec 3, 2024
4a0f137
added condition to handle OPEB not as header
lucakato Dec 5, 2024
dd7168c
Merge pull request #143 from closup/141-OPEB-line-item
lucakato Dec 5, 2024
8e507bc
defined in constants.py
lucakato Dec 5, 2024
30ceaad
Merge pull request #144 from closup/141-OPEB-line-item
lucakato Dec 5, 2024
d61bbc9
handle different date formats in master info sheet
lucakato Dec 8, 2024
d93c264
Merge pull request #146 from closup/145-brea-foonotes-y-n
lucakato Dec 8, 2024
e677e9f
Set up github actions
lucakato Dec 9, 2024
d6f0a33
Merge pull request #148 from closup/147-changelog-automate
lucakato Dec 9, 2024
6bb868c
Update changelog.yml
lucakato Dec 9, 2024
0912d0a
Merge pull request #149 from closup/147-changelog-automate
lucakato Dec 9, 2024
06b9130
Update README.md
lucakato Dec 9, 2024
2a00cbd
Update README.md
lucakato Dec 9, 2024
ec83d3f
Merge pull request #150 from closup/147-changelog-automate
lucakato Dec 9, 2024
16c342b
README, License, Notices, Contributing documentation
lucakato Dec 9, 2024
2eae71c
Merge pull request #151 from closup/147-changelog-automate
lucakato Dec 9, 2024
cea29d9
Update README.md
lucakato Dec 10, 2024
46a3f46
Merge pull request #153 from closup/147-changelog-automate
lucakato Dec 10, 2024
6e5a07e
Change location of changelog.yml
lucakato Dec 10, 2024
440e951
Merge pull request #154 from closup/147-changelog-automate
lucakato Dec 10, 2024
c34527c
Added GH_TOKEN
lucakato Dec 10, 2024
0a744e5
Merge pull request #155 from closup/147-changelog-automate
lucakato Dec 10, 2024
6b1f4ee
Setting up release-config.yml
lucakato Dec 10, 2024
ec70cd3
Merge pull request #156 from closup/147-changelog-automate
lucakato Dec 10, 2024
da10b9f
docs: update changelog for PR #156
github-actions[bot] Dec 10, 2024
ac63506
Update contributing.md and release-config.yml for PR labesl
lucakato Dec 10, 2024
9e63dae
Added more labels for PR changelogs
lucakato Dec 10, 2024
4793a2b
Update CONTRIBUTING.md
lucakato Dec 10, 2024
4d7a43a
Merge pull request #157 from closup/147-changelog-automate
lucakato Dec 10, 2024
aed2960
docs: update changelog for PR #157
github-actions[bot] Dec 10, 2024
2de771f
Added message Natalie requested about warning in-prod
lucakato Dec 16, 2024
c02bbdd
Merge pull request #160 from closup/93-add-production-comment
lucakato Dec 16, 2024
7acb425
docs: update changelog for PR #160
github-actions[bot] Dec 16, 2024
db2759e
Minor Template Edit
sarraha786 Dec 17, 2024
b7d2372
Merge branch 'dev' of https://github.com/closup/process-xbrl into dev
sarraha786 Dec 17, 2024
8eda6aa
added error handling for conversion processes and trying to fix this …
lucakato Jan 12, 2025
f22323c
gitignore
lucakato Jan 12, 2025
5ef668f
Create .env
lucakato Jan 12, 2025
1a91a2f
Remove .env from Git tracking
lucakato Jan 12, 2025
36a19ba
Remove .specstory from Git tracking
lucakato Jan 12, 2025
afe6c1d
Use latest ixbrl viewer plugin 1.4.48
lucakato Jan 12, 2025
4da4cf1
Merge pull request #162 from closup/161-viewer-not-loading
lucakato Jan 12, 2025
969a74e
docs: update changelog for PR #162
github-actions[bot] Jan 12, 2025
97fd74b
attempting to remove submodules completely
kwheelan Jan 12, 2025
cebb6d0
remove submodules
kwheelan Jan 12, 2025
752ce9f
Merge pull request #167 from closup/163-submodule-versions
kwheelan Jan 12, 2025
49002b5
docs: update changelog for PR #167
github-actions[bot] Jan 12, 2025
8265dfa
revert stuff
lucakato Jan 12, 2025
207da3d
@kwheelan fixed last part to use formatted_value()
lucakato Jan 12, 2025
39da81a
Merge pull request #168 from closup/158-dev-review
lucakato Jan 12, 2025
0182509
docs: update changelog for PR #168
github-actions[bot] Jan 12, 2025
8d2300e
remove app.json bc no need to init submods
kwheelan Jan 13, 2025
0b48cf5
fix merge conflicts
kwheelan Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/release-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
categories:
- title: '🚀 Features'
labels:
- 'feature'
- 'enhancement'
- 'high priority'
- title: '🐛 Bug Fixes'
labels:
- 'fix'
- 'bugfix'
- 'bug'
- title: '📝 Documentation'
labels:
- 'documentation'
- 'docs'
- title: '🧰 Maintenance'
labels:
- 'chore'
- 'refactor'
- title: '💻 Technology Updates'
labels:
- 'python'
- 'js'
- 'Javascript'
- 'html'
- 'excel'
- 'xbrl'
- title: '🎨 UI/UX'
labels:
- 'web design'
- 'web app'
- title: '📦 Other Changes' # Default category
labels:
- '*' # Catch-all for PRs with no matching labels

template: |
## Changes
${{CHANGELOG}}

## Contributors
${{CONTRIBUTORS}}

name-template: 'v$RESOLVED_VERSION'
tag-template: 'v$RESOLVED_VERSION'
change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
sort-by: 'title'
sort-direction: 'ascending'
50 changes: 50 additions & 0 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Update Changelog

on:
pull_request:
branches: [dev, main]
types: [opened, synchronize, closed]

jobs:
update_changelog:
# Only run if PR is merged (not just closed)
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
# Need to fetch all history for changelog generation
fetch-depth: 0
# Checkout the branch that the PR is being merged into
ref: ${{ github.event.pull_request.base.ref }}

- name: Configure Git
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

- name: Generate Changelog
uses: mikepenz/release-changelog-builder-action@v4
with:
configuration: ".github/release-config.yml"
# Specify output file
outputFile: "CHANGELOG.md"
# Use PR title and body for changelog entry
failOnError: false
toTag: ${{ github.sha }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Commit and Push Changes
run: |
# Check if there are changes to commit
if git diff --quiet CHANGELOG.md; then
echo "No changes to CHANGELOG.md"
exit 0
fi

git add CHANGELOG.md
git commit -m "docs: update changelog for PR #${{ github.event.pull_request.number }}"
git push origin ${{ github.event.pull_request.base.ref }}
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,15 @@ xbrl_venv/
.venv
venv/

# FLASK API KEY in this environment file
.env

# ignore unsaved Microsoft docs
~$*

# Ignore cursor
.specstory/

# ignore files that change each time we run the app
app/static/output/output.html
app/templates/site/viewer.html
Expand Down
131 changes: 131 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
## 📦 Uncategorized

- Integrate Suresh's fork (with Word features)
- PR: #4
- 5 word integration
- PR: #21
- 20 typed dimensions
- PR: #27
- module import fix
- PR: #29
- 24 acfr edits
- PR: #35
- 25 improve loading wheel
- PR: #40
- 36 template fixes
- PR: #41
- 30 support for new tables
- PR: #49
- 7 sessions
- PR: #51
- 28 image handling
- PR: #38
- #54 implemented custom line items
- PR: #55
- 52 add back button
- PR: #56
- use jinja to download session specific outputs.
- PR: #61
- 58 downloads session
- PR: #70
- Zip download
- PR: #73
- Improve uploads
- PR: #74
- Fix Ogemaw bug
- PR: #79
- 82 fix viewer js
- PR: #84
- Custom line items adjustment to Excel template
- PR: #78
- [PR] improve process updates and design
- PR: #87
- #85 - Fix date parse error
- PR: #88
- #68 improved web design
- PR: #90
- fixed post conversion page not being displayed
- PR: #97
- Adding sessions updates
- PR: #53
- replaced ACFR template with Sarrah upload
- PR: #100
- PIL Import so Heroku deployment works for main branch
- PR: #102
- heroku still fails so updating ver and specifying arelle too
- PR: #103
- fixed arelle ver
- PR: #104
- changed arelle ver again
- PR: #105
- parse and run added
- PR: #106
- 98 address template errors
- PR: #107
- Template update
- PR: #108
- updated ixbrl viewer ver
- PR: #109
- test push of ixbrlviewer.js change
- PR: #110
- try 1.4.8 for ixbrlviewer
- PR: #111
- added a runtime.txt for heroku
- PR: #112
- test deletion of arelle import
- PR: #113
- add back arelle release
- PR: #114
- Fixed --save-viewer issue, use ixbrl-viewer from pip
- PR: #115
- changed handling session using query param
- PR: #116
- opens in new tab
- PR: #118
- opens in new tab
- PR: #117
- parentheses for negative numbers + 'No' business activities
- PR: #123
- Move all partial fixes to dev branch
- PR: #124
- Update .gitignore
- PR: #135
- flask key .env deleted (only local on Luca pc rn)
- PR: #136
- fix heading formatting issues
- PR: #137
- removed context to revert clickable reconciliation tables
- PR: #138
- Open tab only after conversion complete
- PR: #142
- #122 uploading emailed template
- PR: #127
- added condition to handle 'OPEB' to not treat it as header
- PR: #143
- defined in constants.py
- PR: #144
- handle different date formats in master info sheet
- PR: #146
- Set up GitHub actions / CHANGELOG.md for main and dev branches
- PR: #148
- Update changelog.yml
- PR: #149
- Updated README.md
- PR: #150
- README, License, Notices, Contributing documentation
- PR: #151
- Update README.md
- PR: #153
- Change location of changelog.yml
- PR: #154
- Added GITHUB_TOKEN to changelog.yml
- PR: #155
- Setting up release-config.yml
- PR: #156
- 147 changelog automate
- PR: #157
- Added message Natalie requested about warning in-prod
- PR: #160
- 161 viewer not loading
- PR: #162

118 changes: 118 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
# How to Contribute

Thank you for your interest in contributing to our project! This document provides guidelines for contributing.

## Do you want to propose a significant new feature or an important refactoring?

Please contact [email protected]

## Did you find a bug?

* First, search through [existing issues](https://github.com/closup/process-xbrl/issues) to see if the bug has already been reported.
* If not, create a new issue with a clear title and description.
* Include as much relevant information as possible:
* Steps to reproduce the issue
* Expected behavior
* Actual behavior
* Any error messages
* Your environment (OS, Python version, etc.)
* If possible, add a minimal code example that demonstrates the issue

## Want to submit a pull request?

1. First, create an issue describing the change you want to make.
2. Fork the repository and create a new branch from `main`.
3. Make your changes following our coding conventions.
4. Write or update tests as needed.
5. Update documentation as needed.
6. Label your PR with one of the following categories:
- `feature`, `enhancement`, or `high priority` for new features and improvements
- `fix`, `bugfix`, or `bug` for bug fixes
- `documentation` or `docs` for documentation changes
- `chore` or `refactor` for maintenance tasks
- Technology-specific labels (`python`, `js`, `Javascript`, `html`, `excel`, `xbrl`)
- UI/UX labels (`web design`, `web app`)
7. Submit a pull request with a clear title and description.
8. Reference the issue number in your pull request description.

### Pull Request Guidelines

* Follow Python PEP 8 style guide
* Include tests for new features
* Update documentation as needed
* Keep commits focused and atomic
* Write clear commit messages
* Ensure all tests pass before submitting
* Properly label your PR for changelog categorization:
- 🚀 Features: use `feature`, `enhancement`, or `high priority` labels
- 🐛 Bug Fixes: use `fix`, `bugfix`, or `bug` labels
- 📝 Documentation: use `documentation` or `docs` labels
- 🧰 Maintenance: use `chore` or `refactor` labels
- 💻 Technology Updates: use `python`, `js`, `Javascript`, `html`, `excel`, or `xbrl` labels
- 🎨 UI/UX: use `web design` or `web app` labels
- 📦 Other Changes: PRs without any of the above labels will be categorized here

### Code Review Process

1. At least one project maintainer will review your code
2. Changes may be requested
3. Once approved, a maintainer will merge your PR

## Minor Fixes

* Any functionality change should have a GitHub issue opened. For minor changes that affect documentation, you do not need to open up a GitHub issue. Instead you can prefix the title of your PR with "MINOR: " if meets one of the following:
* Grammar, usage and spelling fixes that affect no more than 2 files
* Documentation updates affecting no more than 2 files and not more than 500 words.
* These should still be labeled with `documentation` or `docs` for proper changelog categorization in the 📝 Documentation section

## Proposing Significant Changes

For significant changes (new features, major refactoring):

1. First, open an issue to discuss the proposal
2. Include:
* Detailed description of the change
* Motivation and use cases
* Potential implementation approach
3. Wait for feedback from maintainers before starting implementation

## Licensing

* All contributions must be compatible with our license (see License.txt)
* By contributing, you agree that your contributions will be licensed under the same terms
* All new files should include the University of Michigan copyright notice:
```
Copyright © <2024> The Regents of the University of Michigan
```

## How Contributors Will Be Credited

* All contributors will be acknowledged in our CHANGELOG.md

## Questions or Need Help?

* For questions about contributing, open an issue with the "question" label
* For bug reports, use the "bug" label
* For feature requests, use the "enhancement" label

## Development Setup

* Please refer to the README.md for the development setup

## Code Style

* Follow PEP 8 guidelines
* Use meaningful variable and function names
* Comment complex logic
* Keep functions focused and modular
* Use type hints where appropriate

## Documentation

* Refer to changelog.yml for the changelog when PRs are merged
* Document new features
* Update API documentation
* Include docstrings for new functions/classes


Thank you for contributing to our project! Your efforts help make this project better for everyone.
1 change: 1 addition & 0 deletions License.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Copyright © <2024> The Regents of the University of Michigan
Loading