Skip to content

Commit

Permalink
Helmfile v0.93.2 and minor change in helmfile.bash (GoogleCloudPlatfo…
Browse files Browse the repository at this point in the history
…rm#327)

* Double quote to prevent globbing and word splitting.shellcheck(SC2086)

* To helmfile v.0.93.2

* Update README
  • Loading branch information
naseemkullah authored and LOZORD committed Nov 25, 2019
1 parent 6efb0f4 commit 59c8964
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion helmfile/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM gcr.io/cloud-builders/gcloud

ARG HELM_VERSION=v3.0.0
ARG HELMFILE_VERSION=v0.92.0
ARG HELMFILE_VERSION=v0.93.2

COPY helmfile.bash /builder/helmfile.bash

Expand Down
4 changes: 2 additions & 2 deletions helmfile/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Helm version

At this time this builder is only compatible with helm v3. Added backwards functionality with helm v2 can be added in a subsequent PR if desired.
At this time this builder is only compatible with helm v3. Backwards functionality with helm v2 can be added in a subsequent PR if desired.

## Using this builder with Google Kubernetes Engine

Expand Down Expand Up @@ -50,7 +50,7 @@ You can set the `Helm` and `Helmfile` versions in `cloudbuild.yaml`.
'build',
'--tag=gcr.io/$PROJECT_ID/helm',
'--build-arg', 'HELM_VERSION=v3.0.0',
'--build-arg', 'HELMFILE_VERSION=v0.92.0',
'--build-arg', 'HELMFILE_VERSION=v0.93.2',
'.'
]

Expand Down
2 changes: 1 addition & 1 deletion helmfile/cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ steps:
"--build-arg",
"HELM_VERSION=v3.0.0",
"--build-arg",
"HELMFILE_VERSION=v0.92.0",
"HELMFILE_VERSION=v0.93.2",
".",
]

Expand Down
2 changes: 1 addition & 1 deletion helmfile/helmfile.bash
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ fi
# if GCS_PLUGIN_VERSION is set, install the plugin
if [[ -n $GCS_PLUGIN_VERSION ]]; then
echo "Installing helm GCS plugin version $GCS_PLUGIN_VERSION "
helm plugin install https://github.com/nouney/helm-gcs --version $GCS_PLUGIN_VERSION
helm plugin install https://github.com/nouney/helm-gcs --version "$GCS_PLUGIN_VERSION"
fi

helmfile "$@"
Expand Down

0 comments on commit 59c8964

Please sign in to comment.