Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move from pyyaml to ruamel.yaml to avoid errors on dumping to yaml files #7

Merged
merged 1 commit into from
Nov 23, 2020
Merged

move from pyyaml to ruamel.yaml to avoid errors on dumping to yaml files #7

merged 1 commit into from
Nov 23, 2020

Conversation

morenod
Copy link
Collaborator

@morenod morenod commented Nov 20, 2020

Related to yaml/pyyaml#98

When dumping to yaml files, strings that could be considered numbers are not quoted.

Using ruamel.yaml, strings that could be numbers are correctly quoted

@morenod morenod linked an issue Nov 20, 2020 that may be closed by this pull request
Need to force account information to be passed as a string #3
Closed
@morenod morenod requested a review from dry923 November 20, 2020 11:38
dry923
dry923 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@dry923 dry923 merged commit 511dd15 into cloud-bulldozer:main Nov 23, 2020
@morenod morenod deleted the force_strings branch November 26, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dry923 dry923 dry923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to force account information to be passed as a string
2 participants
@morenod @dry923