Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose a VDP procedure #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Propose a VDP procedure #67

wants to merge 3 commits into from

Conversation

pburkholder
Copy link
Contributor

Changes proposed in this pull request:

  • A standard process for handling VDP/BBP reports.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

BBP/VDP is a public process. The links here are private to GSA/cloud.gov

@pburkholder pburkholder requested a review from wz-gsa July 19, 2024 21:53
@pburkholder
Copy link
Contributor Author

@seanmbazemore or @wz-gsa Is this still helpful or should I close it unmerged?

@pburkholder pburkholder requested a review from a team as a code owner July 19, 2024 21:55
wz-gsa
wz-gsa reviewed Jul 29, 2024
View reviewed changes
RA-Policy.md Outdated Show resolved Hide resolved
wz-gsa
wz-gsa requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@wz-gsa wz-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run this through spell checking before I approve it?

RA-Policy.md Outdated Show resolved Hide resolved
RA-Policy.md Outdated Show resolved Hide resolved
@pburkholder pburkholder force-pushed the peterb/vdp-process-ra5-11 branch from 98f0404 to d501381 Compare August 5, 2024 20:00
@pburkholder
Copy link
Contributor Author

cSpell findings addressed, and addressed some Markdown Lint issues too. Thanks for catching the spelling issues, @wz-gsa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz-gsa wz-gsa wz-gsa requested changes

@seanmbazemore seanmbazemore Awaiting requested review from seanmbazemore

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pburkholder @wz-gsa