Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger for terraform state for plan jobs #888

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add trigger for terraform state for plan jobs #888

merged 1 commit into from
Sep 13, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Sep 13, 2024

Changes proposed in this pull request:

  • Will help with detection of IP CIDR range changes for S3.
  • Once the corresponding "plan" and "apply" jobs are run for an environment in cg-provision's pipeline, those will update the terraform statefile in S3. Changes to the statefiles are then used as data inputs for terraform in this repo. The proposed change here simply looks for updates to the statefile and fires the corresponding environment's "plan" step. It will still need the operator to review the changes and run the "apply" step so the application security groups are updated with the new ip ranges.
  • This should close out https://github.com/cloud-gov/private/issues/1438

Security considerations

No real changes to security, simply quickens the response between when AWS changes IP CIDR ranges and when we reflect these changes within CF ASGs.

@cweibel cweibel requested a review from a team as a code owner September 13, 2024 17:04
@cweibel cweibel merged commit 3bc5201 into main Sep 13, 2024
1 check passed
@cweibel cweibel deleted the tftrigger branch September 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants