chore: refactor @shared/UsaIcon.jsx and test #4668 #4698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
aria-hidden
because node visibility ought to be determined by therole
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hiddenaria-hidden
andfocusable
props, usingrole
to determine visibility and focusabilityfocusable
is nowfalse
by default, and only set totrue
forrole="button"
androle="link"
, per a11y guidelinesxlinkHref
withhref
USWDS-Site: Replaced deprecated xlink:href code with recommended use of href uswds/uswds-site#2926 and https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:hrefrole
must now be one of the following, suitable for icons:img, presentation, button, link, status, none
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Rolessize
must be one of the USWDS icon size options, 3-9 https://designsystem.digital.gov/components/icon/#component-variants-icon@shared/UsaIcon.jsx
#4668security considerations