Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Active Users report for Pages/Zendesk monthly sync #2805

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

svenaas
Copy link
Contributor

@svenaas svenaas commented Dec 7, 2023

Part of cloud-gov/pages-core#4313

cloud-gov/pages-core#4317 introduces an Active Users report which is more suitable than than (All) Users report previously specified for the sync to Zendesk, because it only includes those users who can log in to Pages.

Changes proposed in this pull request:

  • Specify Active Users report for Pages/Zendesk monthly sync

security considerations

None. This is a process change utilizing a report which includes a subset of the records used in the previous process.

@svenaas svenaas force-pushed the specify-active-users-for-pages-zendesk-sync branch from f3f4637 to df7d5f0 Compare December 7, 2023 18:59
@svenaas
Copy link
Contributor Author

svenaas commented Dec 7, 2023

@Ephraim-G I won't merge this until cloud-gov/pages-core#4317 is in (and it won't be applicable until that's released to production) but I think it would be OK to go ahead so that we don't leave this ambiguous.

@svenaas svenaas requested a review from Ephraim-G December 7, 2023 19:00
@svenaas
Copy link
Contributor Author

svenaas commented Dec 7, 2023

OK, merged into pages-core

Copy link
Contributor

@Ephraim-G Ephraim-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenaas Very much appreciated that you were able to prune the report, this will help a lot.

@svenaas svenaas merged commit 017c8e1 into main Dec 7, 2023
@svenaas svenaas deleted the specify-active-users-for-pages-zendesk-sync branch December 7, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants