fix: Added unit tests to achieve 97% code coverage

src/builders.ts

@@ -42,7 +42,7 @@ const DefaultPipelineServiceAccountName = 'default:pipeline';
  * @param sa
  * @param saNamespace
  */
-function createRoleBindingProps(bindingName: string, bindingNs: string, rolename: string, sa: string, saNamespace: string): ApiObjectProps {
+export function createRoleBindingProps(bindingName: string, bindingNs: string, rolename: string, sa: string, saNamespace: string): ApiObjectProps {
   return {
     apiVersion: 'rbac.authorization.k8s.io/v1',
     kind: 'ClusterRoleBinding',
@@ -855,7 +855,7 @@ export class TaskBuilder {
     // First, check to see if there is already a result with this name
     const existing = this._results.find((obj) => obj.name === name);
     if (existing) {
-      throw new Error(`Cannot add result ${name}, as it already exists.`);
+      throw new Error(`Cannot add result '${name}', as it already exists.`);
     }
     this._results.push({
       name: name,

test/pipelinebuilder.test.ts

@@ -10,6 +10,7 @@ import {
   WorkspaceBuilder,
   fromPipelineParam,
   constant,
+  createRoleBindingProps,
   ClusterTaskResolver,
 } from '../src';
 
@@ -40,6 +41,40 @@ class PipelineRunTest extends Chart {
   }
 }
 
+class PipelineRunTestCustom extends Chart {
+  constructor(scope: Construct, id: string, props?: ChartProps) {
+    super(scope, id, props);
+
+    const pipelineParam = new ParameterBuilder('repo-url')
+      .withDefaultValue('');
+
+    const myTask = new TaskBuilder(this, 'git-clone')
+      .withName('fetch-source')
+      .withStringParam(new ParameterBuilder('url').withValue(fromPipelineParam(pipelineParam)));
+
+    const pipeline = new PipelineBuilder(this, 'clone-build-push')
+      .withDescription('This pipeline closes a repository, builds a Docker image, etc.')
+      .withTask(myTask)
+      .withStringParam(pipelineParam);
+    pipeline.buildPipeline({ includeDependencies: true });
+
+    const CRB = createRoleBindingProps(
+      'pipeline-admin-default-crb',
+      'default',
+      'cluster-admin',
+      'pipeline',
+      'default');
+
+    const serviceAccount = 'default:pipeline';
+
+    new PipelineRunBuilder(this, 'my-pipeline-run', pipeline)
+      .withRunParam('repo-url', 'https://github.com/exmaple/my-repo')
+      .withClusterRoleBindingProps(CRB)
+      .withServiceAccount(serviceAccount)
+      .buildPipelineRun({ includeDependencies: true });
+  }
+}
+
 class PipelineRunTestWithUndefinedWorkspaceError extends Chart {
   constructor(scope: Construct, id: string, props?: ChartProps) {
     super(scope, id, props);
@@ -195,6 +230,61 @@ class MyTestChartWithDuplicateParams extends Chart {
   }
 }
 
+class MyTestChartWithPipelineParamError extends Chart {
+  constructor(scope: Construct, id: string, props?: ChartProps) {
+    super(scope, id, props);
+
+    const pipelineParam = new ParameterBuilder('repo-url')
+      .withDefaultValue('');
+
+    const urlParam = new ParameterBuilder('url')
+      .withValue(fromPipelineParam(pipelineParam));
+
+    const myTask = new TaskBuilder(this, 'fetch-source')
+      .withName('git-clone')
+      .withStringParam(urlParam);
+
+    new PipelineBuilder(this, 'clone-build-push')
+      .withDescription('This pipeline closes a repository, builds a Docker image, etc.')
+      .withTask(myTask)
+      .buildPipeline();
+  }
+}
+
+class MyTestChartWithDuplicateResultError extends Chart {
+  constructor(scope: Construct, id: string, props?: ChartProps) {
+    super(scope, id, props);
+
+    const myTask = new TaskBuilder(this, 'fetch-source')
+      .withName('git-clone')
+      .withResult('result', 'The original result')
+      .withResult('result', 'The duplicate result');
+
+    new PipelineBuilder(this, 'clone-build-push')
+      .withDescription('This pipeline closes a repository, builds a Docker image, etc.')
+      .withTask(myTask)
+      .buildPipeline();
+  }
+}
+
+class MyTestChartWithWorkspaceError extends Chart {
+  constructor(scope: Construct, id: string, props?: ChartProps) {
+    super(scope, id, props);
+
+    const myWorkspace = new WorkspaceBuilder('output')
+      .withDescription('The files cloned by the task');
+
+    const myTask = new TaskBuilder(this, 'fetch-source')
+      .withName('git-clone')
+      .withWorkspace(myWorkspace);
+
+    new PipelineBuilder(this, 'clone-build-push')
+      .withDescription('This pipeline closes a repository, builds a Docker image, etc.')
+      .withTask(myTask)
+      .buildPipeline();
+  }
+}
+
 class MyTestChartWithStaticOverride extends Chart {
 
   constructor(scope: Construct, id: string, props?: ChartProps) {
@@ -388,6 +478,13 @@ describe('PipelineBuilderTest', () => {
     expect(results).toMatchSnapshot();
   });
 
+  test('PipelineRunBuilderCustom', () => {
+    const app = Testing.app();
+    const chart = new PipelineRunTestCustom(app, 'test-chart');
+    const results = Testing.synth(chart);
+    expect(results).toMatchSnapshot();
+  });
+
   test('PipelineRunBuilderWithError', () => {
     const app = Testing.app();
     const f = () => {
@@ -426,6 +523,30 @@ describe('PipelineBuilderTest', () => {
     expect(results).toMatchSnapshot();
   });
 
+  test('PipelineBuilderWithPipelineParamError', () => {
+    const app = Testing.app();
+    const f = () => {
+      new MyTestChartWithPipelineParamError(app, 'test-chart');
+    };
+    expect(f).toThrowError('Parameter \'url\' in Task \'git-clone\' expects Pipeline value from parameter \'repo-url\', which is not defined.');
+  });
+
+  test('PipelineBuilderWithDuplicateResults', () => {
+    const app = Testing.app();
+    const f = () => {
+      new MyTestChartWithDuplicateResultError(app, 'test-chart');
+    };
+    expect(f).toThrowError('Cannot add result \'result\', as it already exists.');
+  });
+
+  test('PipelineBuilderWithWorkspaceError', () => {
+    const app = Testing.app();
+    const f = () => {
+      new MyTestChartWithWorkspaceError(app, 'test-chart');
+    };
+    expect(f).toThrowError('Workspace \'output\' in Task \'git-clone\' has no binding to a workspace in Pipeline \'clone-build-push\'.');
+  });
+
   test('PipelineBuilderWithStaticOverride', () => {
     const app = Testing.app();
     const chart = new MyTestChartWithStaticOverride(app, 'test-chart');