Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/addon nginx ingress #19

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Feat/addon nginx ingress #19

merged 7 commits into from
Aug 21, 2023

Conversation

dipak2515
Copy link
Contributor

@dipak2515 dipak2515 commented Aug 10, 2023 •
edited
Loading

  • Changed the structure of this addon as per new tag 0.0.3
  • Added more attributes and variable for these attributes.
  • Updated README.md

@dipak2515 dipak2515 self-assigned this Aug 10, 2023
@clouddrove-ci clouddrove-ci enabled auto-merge (squash) August 14, 2023 01:17
h1manshu98
h1manshu98 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clouddrove-ci clouddrove-ci merged commit c36b53f into master Aug 21, 2023
@clouddrove-ci clouddrove-ci deleted the feat/addon_nginx-ingress branch August 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

@omsharma07 omsharma07 Awaiting requested review from omsharma07

Assignees

@dipak2515 dipak2515

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipak2515 @anmolnagpal @h1manshu98 @clouddrove-ci