Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-25754 Configurable CP region, security group and added destroy script #36

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Jul 29, 2024

No description provided.

@jimright
Copy link
Contributor

@daszabo - can you rebase this PR following the merge of PR#35? I think the only thing that needs reviewing is the provider pinning - we use ~> in eob-devel instead of >=.

Thanks,
Jim

@jimright jimright self-assigned this Jul 30, 2024
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daszabo - all looks good with these changes.

I just had a query about the Azure and GCP destroy scripts; see comments above.

azure/destroy.sh Outdated Show resolved Hide resolved
gcp/destroy.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@jimright jimright merged commit 53ca13f into cloudera-labs:eob-devel Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants