Passing username for impersonation #334

gbrian · 2019-02-04T10:17:45Z

No description provided.

timarmstrong · 2019-02-27T19:26:55Z

Can you add a test for this feature? Maybe you can use the effective_user() builtin function to make sure that it had the intended effect.

gbrian · 2019-02-27T21:01:04Z

Do you mean kind of:

def test_sqlalchemy_impersonation():
    engine = create_engine('impala://localhost')
    result = connection.execute("select effective_user() as effective_user")
    observed = result[0]['effective_user']
    expected = '?????'
    assert expected == observed

    impersonate = 'user1'
    engine = create_engine('impala://%s@localhost' % impersonate)
    result = connection.execute("select effective_user() as effective_user")
    observed = result[0]['effective_user']
    expected = impersonate
    assert expected == observed

timarmstrong · 2019-02-27T21:18:53Z

Something along those lines, yeah. I think the second part of that test is the most important. Mainly to prove that the 'effective_user' value gets plumbed all the way through to Impala correctly.

timarmstrong

Can you add a test for this potentially?

timarmstrong · 2019-02-27T19:22:33Z

impala/dbapi.py

@@ -41,7 +41,7 @@ def connect(host='localhost', port=21050, database=None, timeout=None,
            use_ssl=False, ca_cert=None, auth_mechanism='NOSASL', user=None,
            password=None, kerberos_service_name='impala', use_ldap=None,
            ldap_user=None, ldap_password=None, use_kerberos=None,
-            protocol=None):
+            protocol=None,username=None):


nit: space after comma to be consistent with surrounding code and PEP8

timarmstrong · 2019-02-27T19:22:43Z

impala/hiveserver2.py

        log.debug('HiveServer2Connection(service=%s, default_db=%s)', service,
                  default_db)
        self.service = service
        self.default_db = default_db
+        self.impersonate=impersonate


nit: spaces around = to be consistent with surrounding code and PEP8

timarmstrong · 2019-02-27T19:24:49Z

impala/hiveserver2.py

@@ -122,6 +124,12 @@ def cursor(self, user=None, configuration=None, convert_types=True,

        log.debug('.cursor(): getting new session_handle')

+        if self.impersonate != None:


Should be "is not None" - see https://docs.quantifiedcode.com/python-anti-patterns/readability/comparison_to_none.html

huw0 · 2023-05-22T15:53:33Z

#281 indicates that impersonation works on a per-cursor basis.

Therefore can this PR be closed? I think it will be confusing to support impersonation in multiple places and this could lead to unintentional security issues where connections are re-used.

gbrian · 2023-05-23T11:22:31Z

Not needed

Passing username for impersonation

150776b

timarmstrong reviewed May 16, 2019

View reviewed changes

gbrian closed this May 23, 2023

gbrian reopened this May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Passing username for impersonation #334

Passing username for impersonation #334

gbrian commented Feb 4, 2019

timarmstrong commented Feb 27, 2019

gbrian commented Feb 27, 2019

timarmstrong commented Feb 27, 2019

timarmstrong left a comment

timarmstrong Feb 27, 2019

timarmstrong Feb 27, 2019

timarmstrong Feb 27, 2019

huw0 commented May 22, 2023 •

edited

Loading

gbrian commented May 23, 2023

		@@ -122,6 +124,12 @@ def cursor(self, user=None, configuration=None, convert_types=True,

		log.debug('.cursor(): getting new session_handle')

		if self.impersonate != None:

Passing username for impersonation #334

Are you sure you want to change the base?

Passing username for impersonation #334

Conversation

gbrian commented Feb 4, 2019

timarmstrong commented Feb 27, 2019

gbrian commented Feb 27, 2019

timarmstrong commented Feb 27, 2019

timarmstrong left a comment

Choose a reason for hiding this comment

timarmstrong Feb 27, 2019

Choose a reason for hiding this comment

timarmstrong Feb 27, 2019

Choose a reason for hiding this comment

timarmstrong Feb 27, 2019

Choose a reason for hiding this comment

huw0 commented May 22, 2023 • edited Loading

gbrian commented May 23, 2023

huw0 commented May 22, 2023 •

edited

Loading