Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable removing access application custom attributes and claims #2838

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BSFishy
Copy link

@BSFishy BSFishy commented Aug 7, 2024

Removes the omitempty on Access application custom attributes. This allows an empty list to be passed to remove empty attributes, which would have otherwise been omitted.

closes #2837

Description

Removes the omitempty on Access application custom attributes.

Has your change been tested?

Using the script in #2837

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link

github-actions bot commented Aug 7, 2024

changelog detected ✅

@BSFishy BSFishy force-pushed the custom_attributes_fix branch from eb7115c to b42e365 Compare August 7, 2024 21:32
@BSFishy BSFishy marked this pull request as ready for review August 7, 2024 21:34
@BSFishy BSFishy requested a review from jacobbednarz as a code owner August 7, 2024 21:34
@BSFishy BSFishy force-pushed the custom_attributes_fix branch 2 times, most recently from d6d6ffa to 0d6f00a Compare August 8, 2024 14:52
@ajholland
Copy link

Can you do the same thing for the CustomClaims field? - it's the OIDC version of SAML CustomAttributes

@BSFishy BSFishy force-pushed the custom_attributes_fix branch from 0d6f00a to aa359a1 Compare August 8, 2024 19:56
@BSFishy BSFishy changed the title fix: remove empty access application attributes fix: enable removing access application custom attributes and claims Aug 8, 2024
@jacobbednarz jacobbednarz merged commit 05d4578 into cloudflare:master Aug 9, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Aug 9, 2024
@BSFishy BSFishy deleted the custom_attributes_fix branch August 9, 2024 16:57
Copy link

This functionality has been released in v0.102.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access application custom attributes don't update when removed
3 participants