Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add element.onEndTag js binding #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add element.onEndTag js binding #263

wants to merge 2 commits into from
+73 −2

Conversation

taina0407
Copy link

This PR is to support onEndTag for JS API.
This is the first time I'm working on a Rust project so feel free to suggest any changes

@kornelski
Copy link
Contributor

There's only one EndTag type, so the macro for defining mutation methods seems unnecessary?

@taina0407
Copy link
Author

There's only one EndTag type, so the macro for defining mutation methods seems unnecessary?

You are right. The problem here is EndTag seems missing removed property, so I changed the PR to adding this so we can re-use existing impl_mutations macro instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kornelski kornelski kornelski approved these changes

@jongiddy jongiddy Awaiting requested review from jongiddy jongiddy is a code owner

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy Noah-Kennedy is a code owner

@orium orium Awaiting requested review from orium orium is a code owner

@scotchmist scotchmist Awaiting requested review from scotchmist scotchmist is a code owner

@jasnell jasnell Awaiting requested review from jasnell jasnell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taina0407 @kornelski