Change r2 put response encoding

[robbertvanginkel]

Without this, the await env.MY_BUCKET.put(...) of https://developers.cloudflare.com/r2/api/workers/workers-api-usage/ hangs indefinitely

This problem matches the description in cloudflare/workers-sdk#3688 and https://discord.com/channels/595317990191398933/1138945222873731264/1138945222873731264.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bd74aea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[robbertvanginkel]

The tre branch seems to be where the currently released version of miniflare is? Are there any tests for this behaviour to verify?

I'm not completely sure why encodeResult doesn't work here, but with it I observed that writeResponse for put would get stuck in this loop:

miniflare/packages/miniflare/src/index.ts

Lines 350 to 353 in cf080a8

	if (response.body) {
	for await (const chunk of response.body) {
	if (chunk) initialStream.write(chunk);
	}

[mrbbot]

Hey! 👋 Thanks for the PR! 🙂 I think this may be caused by nodejs/node#48668, which was introduced in Node 20.4.0. It looks like Node 20.3.0 doesn't reproduce this issue. Unfortunately, this fix doesn't properly encode the returned object. If you try something like...

const object = await env.BUCKET.put("key", "value");
return Response.json(object.checksums);

...you'll see checksums is empty, whereas it should always contain an MD5 hash. I've just finished work to port Miniflare's simulators from Node.js to Durable Objects running in workerd. This should also fix the problem, as the issue is in Node.

Tests for this behaviour are here though:

miniflare/packages/miniflare/test/plugins/r2/index.spec.ts

Line 777 in cf080a8

test("put: returns metadata for created object", async (t) => {

They're not currently run on the latest version of Node 20 though. 🙁

[robbertvanginkel]

Thanks for the response! I was already getting a bit confused as I thought this had worked on wrangler v3 before but after returning to a project after a while it had suddenly stopped. Couldn't get it to work by downgrading wrangler/miniflare but didn't think node would have been the issue...

With my node fixed to the LTS version the old code seems to work again, I'll close this out and lets wait for the node fix then.