Use LabelsSource for alerts/absent

internal/checks/alerts_absent.go

@@ -8,10 +8,10 @@ import (
 	"github.com/cloudflare/pint/internal/discovery"
 	"github.com/cloudflare/pint/internal/output"
 	"github.com/cloudflare/pint/internal/parser"
+	"github.com/cloudflare/pint/internal/parser/utils"
 	"github.com/cloudflare/pint/internal/promapi"
 
 	"github.com/prometheus/common/model"
-	promParser "github.com/prometheus/prometheus/promql/parser"
 )
 
 const (
@@ -58,7 +58,15 @@ func (c AlertsAbsentCheck) Check(ctx context.Context, _ discovery.Path, rule par
 		return problems
 	}
 
-	if n, ok := rule.AlertingRule.Expr.Query.Expr.(*promParser.Call); !ok || n.Func.Name != "absent" {
+	var hasAbsent bool
+	src := utils.LabelsSource(rule.AlertingRule.Expr.Query)
+	for _, s := range append(src.Alternatives, src) {
+		if s.Operation == "absent" {
+			hasAbsent = true
+		}
+	}
+
+	if !hasAbsent {
 		return problems
 	}
 

internal/checks/alerts_absent_test.go

@@ -34,6 +34,13 @@ func TestAlertsAbsentCheck(t *testing.T) {
 			prometheus:  newSimpleProm,
 			problems:    noProblems,
 		},
+		{
+			description: "ignores rules with no absent()",
+			content:     "- alert: foo\n  expr: count(foo)\n  for: 2m\n",
+			checker:     newAlertsAbsentCheck,
+			prometheus:  newSimpleProm,
+			problems:    noProblems,
+		},
 		{
 			description: "ignores rules with invalid duration",
 			content:     "- alert: foo\n  expr: absent(foo)\n  for: abc\n",
@@ -47,6 +54,32 @@ func TestAlertsAbsentCheck(t *testing.T) {
 				},
 			},
 		},
+		{
+			description: "count() or absent() without for",
+			content:     "- alert: foo\n  expr: count(foo) > 5 or absent(foo)\n",
+			checker:     newAlertsAbsentCheck,
+			prometheus:  newSimpleProm,
+			problems: func(uri string) []checks.Problem {
+				return []checks.Problem{
+					{
+						Lines: parser.LineRange{
+							First: 2,
+							Last:  2,
+						},
+						Reporter: checks.AlertsAbsentCheckName,
+						Text:     absentForNeeded("prom", uri, "2m"),
+						Details:  checks.AlertsAbsentCheckDetails,
+						Severity: checks.Warning,
+					},
+				}
+			},
+			mocks: []*prometheusMock{
+				{
+					conds: []requestCondition{requireConfigPath},
+					resp:  configResponse{yaml: "global:\n  scrape_interval: 1m\n"},
+				},
+			},
+		},
 		{
 			description: "absent() without for",
 			content:     "- alert: foo\n  expr: absent(foo)\n",