Add show_app_log option to tail and display logs during application start
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterlink
reviewed
Nov 27, 2017
Dockerfile
Outdated
| @@ -3,8 +3,8 @@ RUN apk add --no-cache curl jq | |||
| RUN mkdir -p /assets | |||
| WORKDIR /assets | |||
| RUN curl -L "https://cli.run.pivotal.io/stable?release=linux64-binary&source=github-rel" | tar -xzf - | |||
| RUN url=$(curl -s "https://api.github.com/repos/contraband/autopilot/releases/latest" \ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Published example docker image worked for me |
aeijdenberg
changed the title
show_app_log option to tail and display logs during application startshow_app_log option to tail and display logs during application start
|
I've rebased on latest |
|
thanks! |
|
This is awesome! Minor: the documentation appears to be missing from README.md, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Shoudn't be merged until contraband/autopilot#43 lands, and then the
curlcommand updated to pull from the correct upstream repo)Fixes #28
Also fixes Docker build, which previously uses
jqfeatures not present in the Alpine image.